Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-level flag to disable timeouts #737

Closed
vstepchik opened this issue Apr 1, 2015 · 2 comments
Closed

Add command-level flag to disable timeouts #737

vstepchik opened this issue Apr 1, 2015 · 2 comments

Comments

@vstepchik
Copy link
Contributor

After updating to the last hystrix version I found that synchronous semaphore-isolated commands are affected by the hystrix.command.default.execution.isolation.thread.timeoutInMilliseconds property.
Is there a way to disable timeout for such commands if it's not a bug?

@mattrjacobs
Copy link
Contributor

@vitalatron - This is indeed a new feature of Hystrix 1.4.x.

There's not a specific setting to disable the timeout, though of course you can set the timeout value as arbitrarily high as you'd like.

There are already settings per-command representing boolean enabled flags for other Hystrix features (request log, request cache, circuit-breaker, fallback), so I think it makes sense to add a flag for timeout as well.

I'll update the title of the issue to add this flag and then use it in command invocation.

@mattrjacobs mattrjacobs changed the title Synchronous semaphore-isolated command timeouts Add command-level flag to disable timeouts Apr 1, 2015
@mattrjacobs
Copy link
Contributor

Added in #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants