From 4e34ab11b129d3cab7793a3015bf71311223a25d Mon Sep 17 00:00:00 2001 From: Philipp Katz Date: Mon, 18 Mar 2024 11:36:38 +0100 Subject: [PATCH] Lower logging verbosity from error to warn * there's nothing we can do about these exceptions, anyways, and they are treated as graceful as possible, so `error` doesn't make sense * shorten log output and remove stacktrace * closes #38 --- .../philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/de.philippkatz.knime.jsondocgen.application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java b/de.philippkatz.knime.jsondocgen.application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java index c1a9906..fd88304 100644 --- a/de.philippkatz.knime.jsondocgen.application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java +++ b/de.philippkatz.knime.jsondocgen.application/src/de/philippkatz/knime/jsondocgen/JsonNodeDocuGenerator.java @@ -656,7 +656,7 @@ private static boolean isStreamable(NodeModel nodeModel) { } } catch (NoSuchMethodException e) { // this should never happen, as the method is implemented by the NodeModel class - LOGGER.error(String.format("No createStreamableOperator method in %s", nodeModel.getClass().getName()), e); + LOGGER.warn(String.format("No createStreamableOperator method in %s", nodeModel.getClass().getName())); } return false; } @@ -673,7 +673,7 @@ private static Optional getBundleName(NodeFactory nodeFactory) { method.setAccessible(true); return (Optional) method.invoke(nodeFactory); } catch (ReflectiveOperationException | IllegalArgumentException e) { - LOGGER.error(String.format("Could not call getBundleName for %s", nodeFactory.getClass().getName()), e); + LOGGER.warn(String.format("Could not call getBundleName for %s: %s", nodeFactory.getClass().getName(), e.getMessage())); return Optional.empty(); } }