Merge pull request #9313 from rouault/flatbuffers_namespacing

Make sure our vendored flatbuffers copy has a unique namespace

Author: rouault

ogr/ogrsf_frmts/flatgeobuf/CMakeLists.txt

@@ -11,3 +11,5 @@ add_gdal_driver(
 gdal_standard_includes(ogr_FlatGeobuf)
 target_include_directories(ogr_FlatGeobuf PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
                                                   $<TARGET_PROPERTY:ogrsf_generic,SOURCE_DIR>)
+# Quick and dirty way of modifying the default flatbuffers namespace to gdal_flatbuffers
+target_compile_definitions(ogr_FlatGeobuf PRIVATE -Dflatbuffers=gdal_flatbuffers)

ogr/ogrsf_frmts/flatgeobuf/ogrflatgeobufdataset.cpp

@@ -32,6 +32,12 @@
 
 #include "header_generated.h"
 
+// For users not using CMake...
+#ifndef flatbuffers
+#error                                                                         \
+    "Make sure to build with -Dflatbuffers=gdal_flatbuffers (for example) to avoid potential conflict of flatbuffers"
+#endif
+
 using namespace flatbuffers;
 using namespace FlatGeobuf;
 

scripts/cppcheck.sh

@@ -98,6 +98,7 @@ for dirname in alg port gcore ogr frmts gnm apps fuzzers; do
         -D__x86_64__ \
         -DFLT_EVAL_METHOD \
         -DKDU_HAS_ROI_RECT \
+        -Dflatbuffers=gdal_flatbuffers \
         --include="${CPL_CONFIG_H}" \
         --include=port/cpl_port.h \
         -I "${CPL_CONFIG_H_DIR}" \