Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Look into making TranslationManager a static class rather than a singleton #18

Closed
2 tasks done
japtar10101 opened this issue Sep 11, 2019 · 1 comment
Closed
2 tasks done

[FEATURE] Look into making TranslationManager a static class rather than a singleton #18

japtar10101 opened this issue Sep 11, 2019 · 1 comment
Labels
enhancement New feature or request needs-priority Indicates the priority of the issue has not been determined yet. This is the default priority. split to a package A de-coupling task to split a feature in this project into its own Unity package repository.
Milestone
Modular Packages:...

Comments

@japtar10101
Copy link
Member

japtar10101 commented Sep 11, 2019 •
edited
Loading

Describe the solution you'd like

If memory serves correct, the only thing TranslationManager serves to do is provide events on when the language has changed, and recalling what the last language setting was. If true, it would go a long way in de-coupling this class from Singleton, and make it easier to sell the component separately from this project.

Tasklist

  • Research whether this is a good thing or not. Is it worth it?
  • Figure out what milestones to move this task to.

Additional context

Carry-over from the old Bitbucket Mercurial project:
https://bitbucket.org/OmiyaGames/hg-template-unity-project/issues/58/look-into-making-translationmanager-a
@japtar10101 japtar10101 added enhancement New feature or request needs-priority Indicates the priority of the issue has not been determined yet. This is the default priority. labels Sep 11, 2019
@japtar10101 japtar10101 added the split to a package A de-coupling task to split a feature in this project into its own Unity package repository. label Dec 29, 2019
@japtar10101
Copy link
Member Author

Fix #57 instead of this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs-priority Indicates the priority of the issue has not been determined yet. This is the default priority. split to a package A de-coupling task to split a feature in this project into its own Unity package repository.
Projects
None yet
Milestone
Modular Packages: Localization
Development

No branches or pull requests
1 participant
@japtar10101