Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate WebLocationChecker to a project settings window #47

Closed
5 tasks done
japtar10101 opened this issue Sep 11, 2019 · 1 comment
Closed
5 tasks done
Labels
duplicate This issue or pull request already exists enhancement New feature or request needs-priority Indicates the priority of the issue has not been determined yet. This is the default priority.

Comments

@japtar10101
Copy link
Member

japtar10101 commented Sep 11, 2019

Is your feature request related to a problem? Please describe.

Web Location Checker.

Describe the solution you'd like

It seems Unity is opening up the API to add windows under Project Settings and Preferences. Since the web location checker is shared across the entire project, it'd be better to move the feature to a Project Settings window. If possible, consider moving the entire project to its own Unity package.

Tasklist

  • Look into whether Project Settings data can be accessed on runtime.
    • Yes you can! It also appears one can create asset files in the ProjectSettings folder, like any Unity project settings file.
  • If not, look into the effort of creating a ScriptableObject.
  • Make nearly everything about the WebLocationChecker statically accessible. Store only one instance of its statuses.
  • Look into moving the project into its own Unity package.

Describe alternatives you've considered

The current method, which everything is stored in a Singleton prefab. Not useful, as the information is likely not needed to be set on runtime.

Additional context

Part of an effort to decouple a lot of the Singleton scripts. See Issue #19 .

@japtar10101 japtar10101 added enhancement New feature or request needs-priority Indicates the priority of the issue has not been determined yet. This is the default priority. labels Sep 11, 2019
@japtar10101
Copy link
Member Author

Closing as duplicate to this issue

@japtar10101 japtar10101 added the duplicate This issue or pull request already exists label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request needs-priority Indicates the priority of the issue has not been determined yet. This is the default priority.
Projects
None yet
Development

No branches or pull requests

1 participant