Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brew references to Homebrew Core #866

Closed
max-sixty opened this issue Jul 26, 2022 · 2 comments
Closed

Update brew references to Homebrew Core #866

max-sixty opened this issue Jul 26, 2022 · 2 comments
Labels
devops good first issue Tasks suited for learning the compiler codebase quick-wins

Comments

@max-sixty
Copy link
Member

max-sixty commented Jul 26, 2022

prql-compiler is now in homebrew-core thanks to @ankane.

(edited below)

  • We can change docs to point there.
  • We should probably deprecate our existing formula, generously contributed by @roG0d
  • We can set up a workflow to bump the version in core when we release

Apparently there is an action to automatically bump it: https://github.com/dawidd6/action-homebrew-bump-formula; this might be as simple as https://github.com/dandavison/delta/blob/b3cc0f8cae943ec87a4e7b300af431cecda80b68/.github/workflows/cd.yml#L86-L95.

We have a great workflow atm (thanks @roG0d !), so it would be sad to see that go. Possibly we could put it in a repo, it seems high quality and general enough that others may want to use it.

@max-sixty
Copy link
Member Author

max-sixty commented Jan 19, 2023

Since we moved from prql-compiler to prqlc, we can slightly change the above steps:

@eitsupi
Copy link
Member

eitsupi commented Jun 2, 2023

Closed by #2614

@eitsupi eitsupi closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops good first issue Tasks suited for learning the compiler codebase quick-wins
Projects
None yet
Development

No branches or pull requests

2 participants