Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment fix #15253

Closed
George-avy opened this issue Jul 3, 2020 · 5 comments · Fixed by #15605
Closed

Comment fix #15253

George-avy opened this issue Jul 3, 2020 · 5 comments · Fixed by #15605

Comments

@George-avy
Copy link

https://github.com/PX4/Firmware/blob/400c44b5ef692838aa6f6ac040eb0dff7536b2e8/src/lib/rc/sbus.h#L64

Actually at 100kbps, 25bytes per frame and 8E2 (12bits per character) UART configuration , frame duration is exactly 3ms:

 25chars * 12bits/char / 100000bits/s = 3ms
@George-avy
Copy link
Author

George-avy commented Jul 3, 2020

@julianoes
Copy link
Contributor

Thanks for the note. We would appreciate a pull request with your suggested changes, thanks.

@George-avy
Copy link
Author

George-avy commented Jul 10, 2020

Thanks for the note. We would appreciate a pull request with your suggested changes, thanks.

Yeah, I know...

@nrogelio
Copy link
Contributor

Hi George-avy,

I hope you don't mind I created a PR to add your changes.

Best Regards.

@George-avy
Copy link
Author

Hi George-avy,

I hope you don't mind I created a PR to add your changes.

Best Regards.

Why would I mind? Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants