Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + V keybinding for search variables doesn't work in Windows Terminal #210

Closed
2 tasks done
xBLACKICEx opened this issue Nov 26, 2021 · 6 comments
Closed
2 tasks done

Comments

@xBLACKICEx
Copy link

Before proceeding...

Describe the bug

ctrl + v it's not work,

ctrl+alt+v it work !

Is this a typo on README.md?

Environment

Versions installed:

  • Fish: 3.3.1
  • fzf.fish: 7.3
  • plugin manager: fisher 4.3.0
  • terminal: Windows terminal
  • OS: windows 11 WSL Arch Linux
@PatrickF1
Copy link
Owner

Hi! This might be a windows bug. I never test on windows. But just to make sure, can you

  1. double check your config.fish for an invocation of fzf_configure_bindings to make sure you're not already using custom keybindings
  2. if not, try invoking fzf_configure_bindings and then try Ctrl+V again to see if it works

@xBLACKICEx
Copy link
Author

@PatrickF1

Hi! This might be a windows bug. I never test on windows. But just to make sure, can you

  1. double check your config.fish for an invocation of fzf_configure_bindings to make sure you're not already using custom keybindings
  2. if not, try invoking fzf_configure_bindings and then try Ctrl+V again to see if it works

well i re install fish, and fzf, the result is the same. ctrl+v it not work, than later I found out that this shortcut key is preset in windows terminal.
image
But that doesn't explain why ctrl+alt+v works. So strange
wt-fzf fish-cv-bug
.

@PatrickF1
Copy link
Owner

PatrickF1 commented Nov 28, 2021

I see. But can you run

grep fzf .config/fish/config.fish

(dunno where Windows installs config.fish, but update that path if it is installed elsewhere)
I just want to make sure you're not already invoking fzf_configure_bindings in your config.fish

Anyway, I just did a test and even though Ctrl+V is my keybinding for search variables, Ctrl+Alt+V works as well. So it's possible that Ctrl+V gets intercepted by the windows terminal for paste but Ctrl+Alt+V isn't and fish receives it since Ctrl+V is a subset of Ctrl+Alt+V

@xBLACKICEx
Copy link
Author

image
well look like is clean

@xBLACKICEx
Copy link
Author

@PatrickF1
image

I had the right idea I found the windows terminal setting.json(ctrl+, and click Open JSON file), after comment out ctrl+v, then fzf.fish ctrl+v works.😊

@PatrickF1 PatrickF1 changed the title ctrl + v it's not work, ctrl + alt + v it work ! Ctrl + V keybinding for search variables doesn't work in Windows Terminal Nov 28, 2021
@PatrickF1
Copy link
Owner

Yay glad we resolved this! Thanks for opening this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants