Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date columns incorrectly split #5

Open
kylemondus opened this issue Apr 16, 2024 · 4 comments
Open

Date columns incorrectly split #5

kylemondus opened this issue Apr 16, 2024 · 4 comments

Comments

@kylemondus
Copy link

Hi there,

I noticed that my reading years were wrong - everything was evenly distributed between the years 2001 and 2031. But this corresponds to the days of the month and looking into it I think there may be instances when the date isnt being split accurately. In the source code it looks like dates are split YY/MM/DD, but in my unedited goodreads export the date format is: DD/MM/YYYY.

Maybe this is region specific - I'm in the UK. Its probably a horrible thing to try and code, but maybe just a note on the website somewhere could suggest people check their date format if they run into difficulties.
Thanks

@PaulKlinger
Copy link
Owner

Sure, it should be possible to parse both date formats.

Could you post a snippet of the export file so I can see what it looks like?
I'm also in the UK, and for me the dates are in YYYY/MM/DD format, so it's a bit surprising.

@kylemondus
Copy link
Author

Sorry I checked a little more and the issue is slightly different to how I described.

If I download the goodreads export, I can upload the file and it parses correctly.

But if I open the file and edit fields in other columns (eg, to fix missing page counts) and save, then the days are parsed as years. This happens even though there are no changes made to the date column, it remains as DD/MM/YYYY format.

Actually this happens if I just open and save the file, making no changes. Maybe when saving, a local preference is being applied and changing the date somehow, even though it is not visible? Here is the export file where I have just downloaded it, opened, and saved:

goodreads_library_export(1).csv

@PaulKlinger
Copy link
Owner

Ah, that makes sense, it's some kind of auto formatting done by Excel.
Np, I'll add support for that date format in the next couple of days.

@PaulKlinger
Copy link
Owner

Should work now 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants