Remove using namespace std

[SunBlack]

I suggest to remove using namespace std (only std, but not e.g. std::chrono_literals). Reason: There are some math function which exists as C method and as C++, so it is unclear which the compiler is using.

Example:

pcl/features/src/pfh.cpp

Line 67 in 8163917

if (acos (std::fabs (angle1)) > acos (std::fabs (angle2)))

Here acos is used, which only accepts double values, during std::acos have different overloadings (e.g. for float). Currently you have always to check if there is an using namespace std to get an idea, which version is used. If we disallow usage of using namespace std it is always clear, that acos without std:: isn't the wanted code by us.

[taketwo]

I am a proponent of not using using namespace std neither in headers, nor in implementation files. I believe our headers are already clean of this, but cpp files are probably not. If you are up for the challenge of removing these, you have my full support.

[stale]

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

[kunaltyagi]

1 header is still a culprit: cuda/segmentation/include/pcl/cuda/segmentation/mssegmentation.h

Lots of cpp files though (209) including one header file which is using std inside octree namespace: io/include/pcl/compression/color_coding.h

[gnawme]

I'm trying to push changes for this issue, but I keep getting:

ERROR: Permission to PointCloudLibrary/pcl.git denied to gnawme.

Do I need to request access first? This happens on two different machines in two different OSes.

[kunaltyagi]

You need to push to your fork and then open a PR. PointCloudLibrary/pcl is protected

[gnawme]

I'm trying to push my branch so I can open a PR, like so:

git push -u origin norm.evangelista/PCL-3235-remove-namespace-std

[kunaltyagi]

Your remote (say origin or fork) needs to point to your fork: https://github.com/gnawme/pcl.git. Once this is done, you just need git push -u fork <branch-name>