legion_prof_rs: Check build with no features and release mode.

Author: elliottslaughter

test.py

@@ -898,6 +898,16 @@ def build_cmake(root_dir, tmp_dir, env, thread_count,
 
 def build_legion_prof_rs(root_dir, tmp_dir, env):
     legion_prof_dir = os.path.join(root_dir, 'tools', 'legion_prof_rs')
+
+    # Check the build with various settings to make sure we're not breaking anything
+    allow_unused_variables_env = dict(list(env.items()) + [
+        ('RUSTFLAGS', '-Aunused_variables'), # When not all features are enabled, some variables may be unused
+    ])
+    cmd(['cargo', 'check', '--no-default-features'],
+        env=allow_unused_variables_env, cwd=legion_prof_dir)
+    cmd(['cargo', 'check', '--release'],
+        env=env, cwd=legion_prof_dir)
+
     cmd(['cargo', 'install',
          '--all-features',
          '--locked',

tools/legion_prof_rs/Cargo.toml

@@ -17,7 +17,7 @@ rust-version = "1.74"
 [features]
 default = ["archiver", "client", "server", "viewer"]
 archiver = ["dep:legion_prof_viewer"]
-client = ["dep:legion_prof_viewer", "dep:url", "legion_prof_viewer?/client"]
+client = ["dep:legion_prof_viewer", "legion_prof_viewer?/client"]
 server = ["dep:legion_prof_viewer", "legion_prof_viewer?/server"]
 viewer = ["dep:legion_prof_viewer"]
 
@@ -32,7 +32,7 @@ rayon = "1.7"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
 legion_prof_viewer = { version = "0.2.2", optional = true }
-url = { version = "2", optional = true }
+url = { version = "2" }
 slice-group-by = "0.3" # because &[]::group_by is unstable
 log = "0.4"
 env_logger = "0.10"

tools/legion_prof_rs/src/main.rs

@@ -7,12 +7,12 @@ use clap::{Args, Parser, Subcommand};
 
 use rayon::prelude::*;
 
+use url::Url;
+
 #[cfg(feature = "client")]
 use legion_prof_viewer::{
     app, deferred_data::DeferredDataSource, http::client::HTTPClientDataSource,
 };
-#[cfg(feature = "client")]
-use url::Url;
 
 #[cfg(feature = "archiver")]
 use legion_prof::backend::archiver;