ci: fix nightly warning about unreachable pattern (#4437)

davidhewitt · davidhewitt · commit 146c39705d9a · 2024-09-15T21:39:09.000+01:00
* ci: fix nightly warning about unreachable pattern

* add comment
diff --git a/src/sync.rs b/src/sync.rs
@@ -126,10 +126,9 @@ impl<T> GILOnceCell<T> {
             return value;
         }
 
-        match self.init(py, || Ok::<T, std::convert::Infallible>(f())) {
-            Ok(value) => value,
-            Err(void) => match void {},
-        }
+        // .unwrap() will never panic because the result is always Ok
+        self.init(py, || Ok::<T, std::convert::Infallible>(f()))
+            .unwrap()
     }
 
     /// Like `get_or_init`, but accepts a fallible initialization function. If it fails, the cell

Original file line number	Diff line number	Diff line change
`@@ -126,10 +126,9 @@ impl<T> GILOnceCell<T> {`
`126`	`126`	`return value;`
`127`	`127`	`}`
`128`	`128`
`129`		`- match self.init(py, \|\| Ok::<T, std::convert::Infallible>(f())) {`
`130`		`- Ok(value) => value,`
`131`		`- Err(void) => match void {},`
`132`		`- }`
	`129`	`+ // .unwrap() will never panic because the result is always Ok`
	`130`	`+ self.init(py, \|\| Ok::<T, std::convert::Infallible>(f()))`
	`131`	`+ .unwrap()`
`133`	`132`	`}`
`134`	`133`
`135`	`134`	/// Like `get_or_init`, but accepts a fallible initialization function. If it fails, the cell