refactor(character): Use tutorial natives instead of manual bucket setting (#480)

* refactor(character): Use tutorial natives instead of manual bucket setting

* fix: spacing

---------

Co-authored-by: Robin Bird <googleoblivion@users.noreply.github.com>
Co-authored-by: Matthew <22198949+mafewtm@users.noreply.github.com>

Author: 3 people

client/character.lua

@@ -369,8 +369,11 @@ local function chooseCharacter()
     Wait(1000)
     SetEntityCoords(cache.ped, randomLocation.pedCoords.x, randomLocation.pedCoords.y, randomLocation.pedCoords.z, false, false, false, false)
     SetEntityHeading(cache.ped, randomLocation.pedCoords.w)
-    ---@diagnostic disable-next-line: missing-parameter
-    lib.callback.await('qbx_core:server:setCharBucket')
+
+    if not NetworkIsInTutorialSession() then
+        NetworkStartSoloTutorialSession()
+    end
+
     Wait(1500)
     ShutdownLoadingScreen()
     ShutdownLoadingScreenNui()

client/events.lua

@@ -8,6 +8,10 @@ RegisterNetEvent('QBCore:Client:OnPlayerLoaded', function()
         NetworkSetFriendlyFireOption(true)
     end
 
+    if NetworkIsInTutorialSession() then
+        NetworkEndTutorialSession()
+    end
+
     local motd = GetConvar('qbx:motd', '')
     if motd ~= '' then
         exports.chat:addMessage({ template = motd })

server/character.lua

@@ -41,7 +41,6 @@ lib.callback.register('qbx_core:server:loadCharacter', function(source, citizenI
     local success = Login(source, citizenId)
     if not success then return end
 
-    SetPlayerBucket(source, 0)
     logger.log({
         source = 'qbx_core',
         webhook = config.logging.webhook['joinleave'],
@@ -62,19 +61,11 @@ lib.callback.register('qbx_core:server:createCharacter', function(source, data)
     if not success then return end
 
     giveStarterItems(source)
-    if GetResourceState('qbx_spawn') == 'missing' then
-        SetPlayerBucket(source, 0)
-    end
 
     lib.print.info(('%s has created a character'):format(GetPlayerName(source)))
     return newData
 end)
 
-lib.callback.register('qbx_core:server:setCharBucket', function(source)
-    SetPlayerBucket(source, source)
-    assert(GetPlayerRoutingBucket(source) == source, 'Multicharacter bucket not set.')
-end)
-
 RegisterNetEvent('qbx_core:server:deleteCharacter', function(citizenId)
     local src = source
     DeleteCharacter(src --[[@as number]], citizenId)