Skip to content

Commit 00993a4

Browse files
mergify[bot]ElePT
andauthored
Pin symengine in backwards compatibility tests (#13885) (#13886)
* Add symengine constraint in qpy backwards compat tests * Add comments * Only pin upper limit * Update comment (cherry picked from commit 8c06fd2) Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
1 parent 69eb2aa commit 00993a4

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

requirements.txt

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ python-dateutil>=2.8.0
77
stevedore>=3.0.0
88
typing-extensions
99

10-
# If updating the version range here, consider updating 'test/qpy_compat/run_tests.sh' to update the
11-
# list of symengine dependencies used in the cross-version tests.
10+
# If updating the version range here, consider updating the
11+
# list of symengine dependencies used in the cross-version tests
12+
# in 'test/qpy_compat/run_tests.sh' and 'test/qpy_compat/qpy_test_constraints.txt'
1213
symengine>=0.11,<0.14
+5
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,7 @@
11
numpy===1.24.4
22
scipy===1.10.1
3+
4+
# This is a loose constraint because we want to test different versions,
5+
# as defined in 'test/qpy_compat/run_tests.sh', but any symengine version
6+
# above (and including) 0.14 will be incompatible with qpy.
7+
symengine<0.14

test/qpy_compat/run_tests.sh

+2
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ popd
5757
# This will likely duplicate the base dev-compatibility test, but the tests are fairly fast, and
5858
# it's better safe than sorry with the serialisation tests.
5959

60+
# Note that the constraint in the range of symengine versions is logically duplicated
61+
# in `qpy_test_constraints.txt`
6062
symengine_versions=(
6163
'>=0.11,<0.12'
6264
'>=0.13,<0.14'

0 commit comments

Comments
 (0)