Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No favicon.ico #14

Closed
wgasowski opened this issue Dec 17, 2014 · 4 comments
Closed

No favicon.ico #14

wgasowski opened this issue Dec 17, 2014 · 4 comments
Labels

Comments

@wgasowski
Copy link

There is no favicon.ico inside directory with generated files.

Update: there is also no favicon-*.png files.

@phbernard phbernard added the bug label Dec 18, 2014
@phbernard
Copy link
Contributor

Thank you for reporting.

My bad. There was a change in the non-interactive API: these icons are generated only when the desktop_browser section is present in the parameters.

I added a section in the non-interactive API doc. I also need to update the tests of the Grunt plugin to make this clear.

@luixxiul
Copy link

luixxiul commented Jan 7, 2015

Is this not fixed yet, @phbernard ?

@phbernard
Copy link
Contributor

For the "warning" part in the doc: Yep, that's done.

For the tests: nope, not yet. I'll go through the plugin TODO list in a week.

@phbernard
Copy link
Contributor

Well, a week or two :-/

Done, desktop_browser section added to the first scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants