Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid color in webmanifest file #21

Closed
bjarnef opened this issue Jan 18, 2019 · 3 comments · Fixed by RealFaviconGenerator/rfg-api#26
Closed

Invalid color in webmanifest file #21

bjarnef opened this issue Jan 18, 2019 · 3 comments · Fixed by RealFaviconGenerator/rfg-api#26

Comments

@bjarnef
Copy link

bjarnef commented Jan 18, 2019

It seems the color in the generated site.webmanifest is not a valid color.

image

image

The generated json in site.webmanifest looks like this.

{
    "name": "My brand",
    "short_name": "Brand",
    "icons": [
        {
            "src": "/dist/img/favicon/android-chrome-36x36.png",
            "sizes": "36x36",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-48x48.png",
            "sizes": "48x48",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-72x72.png",
            "sizes": "72x72",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-96x96.png",
            "sizes": "96x96",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-144x144.png",
            "sizes": "144x144",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-256x256.png",
            "sizes": "256x256",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-384x384.png",
            "sizes": "384x384",
            "type": "image/png"
        },
        {
            "src": "/dist/img/favicon/android-chrome-512x512.png",
            "sizes": "512x512",
            "type": "image/png"
        }
    ],
    "theme_color": "#_c_d9_a34",
    "background_color": "#_c_d9_a34"
}

@DerianAndre
Copy link

Your hex color code must be lowercase, try that.

@bjarnef
Copy link
Author

bjarnef commented Mar 24, 2019

@DerianAndre it is already lowercase hex code, but why should that matter, both uppercase and lowercase hex codes are valid in CSS and JavaScript.

@bjarnef
Copy link
Author

bjarnef commented Mar 24, 2019

The problem is that it add underscore in the generated hex codes, eg. #_c_d9_a34 in site.webmanifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants