fix(toast): remove boolean toast attribute (#1761)

* fix(alert): removed deprecated toast property

* chore(alert): add changeset

* chore(alert): update changeset

Author: zeroedin

.changeset/odd-bugs-repair.md

@@ -0,0 +1,27 @@
+---
+"@rhds/elements": minor
+---
+
+`<rh-alert>`: removed deprecated toast boolean attribute
+
+  Before: 
+  ```html
+  <rh-alert toast>
+    <h3 slot="header">Default</h3>
+    <p>
+      Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam eleifend
+      elit sed est egestas, a sollicitudin mauris tincidunt.
+    </p>
+  </rh-alert>
+  ```
+
+  After:
+  ```html
+  <rh-alert variant="toast">
+    <h3 slot="header">Default</h3>
+    <p>
+      Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam eleifend
+      elit sed est egestas, a sollicitudin mauris tincidunt.
+    </p>
+  </rh-alert>
+  ```

elements/rh-alert/rh-alert.ts

@@ -85,9 +85,6 @@ export class RhAlert extends LitElement {
    */
   @property({ reflect: true }) variant?: 'alternate' | 'toast' | 'inline';
 
-  /** @deprecated */
-  @property({ reflect: true, type: Boolean }) toast = false;
-
   /**
    * Alert variants have different rules regarding their ability to be dismissed by a user.
    * Default, Info, and Success Inline alerts can be dismissed by a user selecting the close button.
@@ -105,17 +102,6 @@ export class RhAlert extends LitElement {
     }
   }
 
-  willUpdate(changed: PropertyValues<this>) {
-    // toast as a boolean attr is deprecated, so this replicates the previous behaviour
-    if (changed.has('toast') && this.toast) {
-      this.variant = 'toast';
-    }
-    // variant as a boolean attr is deprecated, so this replicates the previous behaviour
-    if (changed.has('variant') && (this.variant as unknown as boolean) === false) {
-      this.variant = undefined;
-    }
-  }
-
   render() {
     const hasActions = this.#slots.hasSlotted('actions');
     const hasBody = this.#slots.hasSlotted(SlotController.anonymous as unknown as string);