Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] <rh-tile> using wrong font size for headings #1591

Closed
marionnegp opened this issue Jun 5, 2024 · 1 comment · Fixed by #1692
Closed

[bug] <rh-tile> using wrong font size for headings #1591

marionnegp opened this issue Jun 5, 2024 · 1 comment · Fixed by #1692
Assignees
@markcaron
Labels
bug Something isn't working good 1st issue Good first issue red hack day Good issue for Red Hack Day
Milestone
2024/Q2 — Charman...

Comments

@marionnegp
Copy link
Collaborator

marionnegp commented Jun 5, 2024 •
edited
Loading

Describe the bug

The tile demo on its docs Overview page is showing an <h2> with a 28px font size because the font size is coming from typography.css. The element should define the heading size.

Which Component?

rh-tile

Steps to reproduce

Visit demo on Tile's Overview page

Expected behaviour

Heading for tile should be:

  • 20px for link tile at default size
  • 18px for link tile at compact size
  • 18px for selectable tiles

Screenshots

No response

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

More browser information

No response

Additional Info

No response
@marionnegp marionnegp added the bug Something isn't working label Jun 5, 2024
@markcaron markcaron added good 1st issue Good first issue red hack day Good issue for Red Hack Day labels Jun 12, 2024
@marionnegp marionnegp changed the title [bug] <rh-tile> demo showing wrong font size [bug] <rh-tile> using wrong font size for headings Jun 17, 2024
@markcaron markcaron moved this from Backlog to In Progress 🟢 in Red Hat Design System Jul 3, 2024
@markcaron markcaron self-assigned this Jul 3, 2024
@markcaron
Copy link
Collaborator

@marionnegp I think quite a bit of the font-sizes are off or at least left open to inheriting the 1rem / 16px body text from <rh-tile>.

The default slot font-size is 16px, which seems like it should be 18px in the specs.

@markcaron markcaron mentioned this issue Jul 3, 2024
Merged
@markcaron markcaron moved this from In Progress 🟢 to Done ☑️ in Red Hat Design System Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markcaron markcaron

Labels
bug Something isn't working good 1st issue Good first issue red hack day Good issue for Red Hack Day
Projects
Red Hat Design System
Status: Done ☑️
Milestone
2024/Q2 — Charmander release
Development

Successfully merging a pull request may close this issue.

fix(tile): tile headline size RedHat-UX/red-hat-design-system
2 participants
@markcaron @marionnegp