You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think @adamjohnson and I agree that we like the idea of @container queries being the default and having to explicitly set query="media" on a grid if they want to use a @media query based container.
But would this be a good thing due to history and the technical debt of the past? Developers are currently used to @media and @container is the new hotness. Are we being too future-forward? I hope I am wrong here and it isn't a big deal to go container first. Thoughts?
As devil's advocate, the negative side of the container default is that the container needs to exist for the container query-based grids to function. In a default scenario, if the grid is dropped on a page with no container, the queries would not take place resulting in stacked items. Or if a parent container exists but is itself a grid and the area in which the rhx-grid is added may not result in the expectations of the implementation. crude example: https://codepen.io/zeroedin/pen/wvLJWyx
Or if a parent container exists but is itself a grid and the area in which the rhx-grid is added may not result in the expectations of the implementation.
I wonder if we should explicitly set container-name: rhx-grid;? If we're already going to require users to add container-type: inline-size;, including container-name in that copy-pasta block seems like no big deal.
Usage Instructions
Copy and paste the following two lines of CSS onto your component's container:
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I think @adamjohnson and I agree that we like the idea of
@container
queries being the default and having to explicitly setquery="media"
on a grid if they want to use a @media query based container.But would this be a good thing due to history and the technical debt of the past? Developers are currently used to
@media
and@container
is the new hotness. Are we being too future-forward? I hope I am wrong here and it isn't a big deal to go container first. Thoughts?As devil's advocate, the negative side of the container default is that the container needs to exist for the container query-based grids to function. In a default scenario, if the grid is dropped on a page with no container, the queries would not take place resulting in stacked items. Or if a parent container exists but is itself a grid and the area in which the
rhx-grid
is added may not result in the expectations of the implementation. crude example: https://codepen.io/zeroedin/pen/wvLJWyxBeta Was this translation helpful? Give feedback.
All reactions