Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Godot] CanvasItem light_mask is ignored by LightOccluder2D occluder_light_mask #32

Open
joshmossas opened this issue Oct 1, 2024 · 9 comments
Labels
bug confirmed topic:rendering topic:2d tracked:godot Issue already tracker on the godot issue tracker

Comments

@joshmossas
Copy link

Tested versions

v4.0.alpha14.official

System information

Ubuntu, Nvidia

Issue description

See original issue:
godotengine/godot#64939

This issue has been open since Aug 26, 2022 and has 54 thumbs up from other developers.

From the original poster:

By setting CanvasItem light_mask to a different layer than LightOccluder2D light_mask, it was possible to have shadows not being drawn on top of sprites. This does no longer work.

Especially in topdown games you generally need this to work.

Steps to reproduce

From the original poster:

  1. Set your PointLight2D's range_item_cull_mask to cover layer 1 and 2
  2. Set your Sprite2D's light_mask to 2 only
  3. Add LightOccluder2D that remains on default for occluder_light_mask and light_mask (layer 1)
  4. have the LightOccluder2D polygon cover (part of) the sprite
  5. hit F6 and note that the shadow is rendered on top of the sprite. the shadow should not be rendered on top of the sprite as is the case in Godot 3.

Minimal reproduction project (MRP)

From the original poster:

projects for both godot 3 and 4 to compare:

light-occluder-sprite-bug.zip

@Salvakiya Salvakiya added the bug label Oct 1, 2024
@Redot-Engine Redot-Engine deleted a comment Oct 6, 2024
@jawbroken
Copy link

why are you reporting real bugs here? the guy who made this fork can't code or fix them. report them to the real project

@joshmossas
Copy link
Author

@jawbroken Your comment isn't really productive

Also this bug has been reported on the original repo and it's been open for more than 2 years (I even linked it in the original post).

The devs here said they wanted to fix long standing issues so I'm shedding light on some of those issues. Only time will tell whether the Redot team actually fulfills their promise. However, I figured it'd be good to at least give them the benefit of the doubt and see where the project goes.

@jawbroken
Copy link

just trying to help, sorry. you're probably better off reporting it to the fork for anime chomos instead, because at least they worked out how to change the logo

@joshmossas
Copy link
Author

Lol is that even a serious project? It looks like a meme.

@jawbroken
Copy link

no, and, neither is this one. that's why i was trying to help…

@joshmossas
Copy link
Author

I suppose I walked into that one... 😅

Anyway as I said before. I'm giving Redot the benefit of the doubt. Maybe they'll produce a useful fork maybe they won't, but only time will tell.

@jawbroken
Copy link

oh…my bad. i didn't realise you incorrectly thought that this was a fork designed to solve issues or be useful in any way. it's actually a grievance-based fork made by, and for, morons who don't have any capability to actually develop a game engine in any way. hope you can get the real project interested in your bugs 🐛

@Spartan322 Spartan322 added tracked:godot Issue already tracker on the godot issue tracker topic:rendering topic:2d confirmed labels Oct 14, 2024
@Spartan322 Spartan322 changed the title CanvasItem light_mask is ignored by LightOccluder2D occluder_light_mask (Ported From Godot) [Godot] CanvasItem light_mask is ignored by LightOccluder2D occluder_light_mask Oct 14, 2024
@SkogiB
Copy link
Contributor

SkogiB commented Oct 14, 2024

Yes, this seems like a totally forgotten issue on Godot. If you find more PRs/issues relating to this, please do link them here.

@joshmossas
Copy link
Author

It looks like this has been fixed upstream godotengine/godot#64939 (comment) (relevant PR godotengine/godot#98835)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed topic:rendering topic:2d tracked:godot Issue already tracker on the godot issue tracker
Projects
Status: Open
Development

No branches or pull requests

5 participants