Skip to content

Commit 549db6c

Browse files
committed
remove SimpleBackend
1 parent 0a2a6c8 commit 549db6c

File tree

6 files changed

+2
-208
lines changed

6 files changed

+2
-208
lines changed

benches/bench.rs

-8
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ use self::setup::{
55
BackendBenchmark,
66
BenchBucket,
77
BenchBuffer,
8-
BenchSimple,
98
BenchString,
109
BENCH_LEN_STRINGS,
1110
BENCH_STRING_LEN,
@@ -76,7 +75,6 @@ fn bench_get_or_intern_static(c: &mut Criterion) {
7675
},
7776
);
7877
}
79-
bench_for_backend::<BenchSimple>(&mut g);
8078
bench_for_backend::<BenchBucket>(&mut g);
8179
bench_for_backend::<BenchString>(&mut g);
8280
bench_for_backend::<BenchBuffer>(&mut g);
@@ -103,7 +101,6 @@ fn bench_get_or_intern_fill_with_capacity(c: &mut Criterion) {
103101
},
104102
);
105103
}
106-
bench_for_backend::<BenchSimple>(&mut g);
107104
bench_for_backend::<BenchBucket>(&mut g);
108105
bench_for_backend::<BenchString>(&mut g);
109106
bench_for_backend::<BenchBuffer>(&mut g);
@@ -130,7 +127,6 @@ fn bench_get_or_intern_fill(c: &mut Criterion) {
130127
},
131128
);
132129
}
133-
bench_for_backend::<BenchSimple>(&mut g);
134130
bench_for_backend::<BenchBucket>(&mut g);
135131
bench_for_backend::<BenchString>(&mut g);
136132
bench_for_backend::<BenchBuffer>(&mut g);
@@ -157,7 +153,6 @@ fn bench_get_or_intern_already_filled(c: &mut Criterion) {
157153
},
158154
);
159155
}
160-
bench_for_backend::<BenchSimple>(&mut g);
161156
bench_for_backend::<BenchBucket>(&mut g);
162157
bench_for_backend::<BenchString>(&mut g);
163158
bench_for_backend::<BenchBuffer>(&mut g);
@@ -184,7 +179,6 @@ fn bench_resolve_already_filled(c: &mut Criterion) {
184179
},
185180
);
186181
}
187-
bench_for_backend::<BenchSimple>(&mut g);
188182
bench_for_backend::<BenchBucket>(&mut g);
189183
bench_for_backend::<BenchString>(&mut g);
190184
bench_for_backend::<BenchBuffer>(&mut g);
@@ -211,7 +205,6 @@ fn bench_get_already_filled(c: &mut Criterion) {
211205
},
212206
);
213207
}
214-
bench_for_backend::<BenchSimple>(&mut g);
215208
bench_for_backend::<BenchBucket>(&mut g);
216209
bench_for_backend::<BenchString>(&mut g);
217210
bench_for_backend::<BenchBuffer>(&mut g);
@@ -246,7 +239,6 @@ fn bench_iter_already_filled(c: &mut Criterion) {
246239
},
247240
);
248241
}
249-
bench_for_backend::<BenchSimple>(&mut g);
250242
bench_for_backend::<BenchBucket>(&mut g);
251243
bench_for_backend::<BenchString>(&mut g);
252244
bench_for_backend::<BenchBuffer>(&mut g);

benches/setup.rs

+1-7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use string_interner::{
2-
backend::{Backend, BucketBackend, BufferBackend, SimpleBackend, StringBackend},
2+
backend::{Backend, BucketBackend, BufferBackend, StringBackend},
33
DefaultSymbol,
44
StringInterner,
55
};
@@ -118,12 +118,6 @@ impl BackendBenchmark for BenchBucket {
118118
type Backend = BucketBackend<DefaultSymbol>;
119119
}
120120

121-
pub struct BenchSimple;
122-
impl BackendBenchmark for BenchSimple {
123-
const NAME: &'static str = "SimpleBackend";
124-
type Backend = SimpleBackend<DefaultSymbol>;
125-
}
126-
127121
pub struct BenchString;
128122
impl BackendBenchmark for BenchString {
129123
const NAME: &'static str = "StringBackend";

src/backend/mod.rs

+1-7
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,10 @@
66
77
mod bucket;
88
mod buffer;
9-
mod simple;
109
mod string;
1110

1211
#[cfg(feature = "backends")]
13-
pub use self::{
14-
bucket::BucketBackend,
15-
buffer::BufferBackend,
16-
simple::SimpleBackend,
17-
string::StringBackend,
18-
};
12+
pub use self::{bucket::BucketBackend, buffer::BufferBackend, string::StringBackend};
1913
use crate::Symbol;
2014

2115
/// The default backend recommended for general use.

src/backend/simple.rs

-168
This file was deleted.

src/lib.rs

-4
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,6 @@
118118
//! Some operations are even slightly more efficient and it consumes less memory.
119119
//! However, all this is at the costs of a less efficient resolution of symbols.
120120
//! Note that the symbols generated by the `BufferBackend` are not contiguous.
121-
//!
122-
//! ### Simple Backend
123-
//!
124-
//! Never use this one for real use cases!
125121
126122
#[cfg(not(feature = "std"))]
127123
extern crate alloc;

tests/tests.rs

-14
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@ impl BackendStats for backend::BucketBackend<DefaultSymbol> {
4141
const NAME: &'static str = "BucketBackend";
4242
}
4343

44-
impl BackendStats for backend::SimpleBackend<DefaultSymbol> {
45-
const MIN_OVERHEAD: f64 = 2.1;
46-
const MAX_OVERHEAD: f64 = 2.33;
47-
const MAX_ALLOCATIONS: usize = 1000040;
48-
const MAX_DEALLOCATIONS: usize = 38;
49-
const NAME: &'static str = "SimpleBackend";
50-
}
51-
5244
impl BackendStats for backend::StringBackend<DefaultSymbol> {
5345
const MIN_OVERHEAD: f64 = 1.7;
5446
const MAX_OVERHEAD: f64 = 1.93;
@@ -377,12 +369,6 @@ mod bucket_backend {
377369
gen_tests_for_backend!(backend::BucketBackend<DefaultSymbol>);
378370
}
379371

380-
mod simple_backend {
381-
use super::*;
382-
383-
gen_tests_for_backend!(backend::SimpleBackend<DefaultSymbol>);
384-
}
385-
386372
mod string_backend {
387373
use super::*;
388374

0 commit comments

Comments
 (0)