Receive monitor requests from any address, team messages only from interface (#20)

Author: ahasselbring

README.md

@@ -64,7 +64,7 @@ In addition, the GameController offers an interface for monitor applications (su
 
 The user must ensure that all of the aforementioned network communication channels are allowed to be used by the firewall.
 The GameController runs on a specific network interface, which generally specifies where packets are sent and from where they are received.
-The exceptions are that control messages can be configured to be sent to the limited broadcast address (`255.255.255.255`) instead of the interface's broadcast address, and that team messages are received from any address.
+The exceptions are that control messages can be configured to be sent to the limited broadcast address (`255.255.255.255`) instead of the interface's broadcast address, and that monitor requests are received from any address.
 
 ## Usage
 

game_controller_net/src/monitor_request_receiver.rs

@@ -1,4 +1,7 @@
-use std::{cmp::min, net::IpAddr};
+use std::{
+    cmp::min,
+    net::{IpAddr, Ipv4Addr, Ipv6Addr},
+};
 
 use anyhow::Result;
 use bytes::Bytes;
@@ -19,7 +22,14 @@ impl MonitorRequestReceiver {
     /// This function creates a new receiver for monitor requests.
     pub async fn new(address: IpAddr, event_sender: mpsc::UnboundedSender<Event>) -> Result<Self> {
         Ok(Self {
-            socket: UdpSocket::bind((address, MONITOR_REQUEST_PORT)).await?,
+            socket: UdpSocket::bind((
+                match address {
+                    IpAddr::V4(_) => IpAddr::V4(Ipv4Addr::UNSPECIFIED),
+                    IpAddr::V6(_) => IpAddr::V6(Ipv6Addr::UNSPECIFIED),
+                },
+                MONITOR_REQUEST_PORT,
+            ))
+            .await?,
             event_sender,
         })
     }

game_controller_net/src/team_message_receiver.rs

@@ -1,6 +1,6 @@
 use std::{
     cmp::min,
-    net::{IpAddr, Ipv4Addr, Ipv6Addr, SocketAddr},
+    net::{IpAddr, Ipv4Addr, SocketAddr},
 };
 
 use anyhow::Result;
@@ -34,14 +34,8 @@ impl TeamMessageReceiver {
         Ok(Self {
             socket: {
                 // This might be stuff that should not be done in an async function.
-                let socket_address: SockAddr = SocketAddr::new(
-                    match address {
-                        IpAddr::V4(_) => IpAddr::V4(Ipv4Addr::UNSPECIFIED),
-                        IpAddr::V6(_) => IpAddr::V6(Ipv6Addr::UNSPECIFIED),
-                    },
-                    TEAM_MESSAGE_PORT_BASE + (team as u16),
-                )
-                .into();
+                let socket_address: SockAddr =
+                    SocketAddr::new(address, TEAM_MESSAGE_PORT_BASE + (team as u16)).into();
                 let raw_socket =
                     Socket::new(socket_address.domain(), Type::DGRAM, Some(Protocol::UDP))?;
                 #[cfg(target_os = "macos")]