bumping coverage to 100%

Author: mavarazy

src/Engine.js

@@ -7,9 +7,9 @@ class Engine {
     this.rules = rules;
     if (isDevelopment()) {
       let conditions = rules.map(rule => rule.conditions);
-      validatePredicates(conditions);
       if (schema !== undefined && schema !== null) {
         if (isObject(schema)) {
+          validatePredicates(conditions);
           validateConditionFields(conditions, schema)
         } else {
           toError(`Expected valid schema object, but got - ${schema}`)

test/Engine.invalid.test.js

@@ -28,12 +28,12 @@ let schema = {
 };
 
 test("ignore invalid rules if no schema provided", () => {
-  expect(() => new Engine(invalidRules)).not.toBeUndefined();
+  expect(() => new Engine(invalidRules)).not.toThrow();
 });
 
-test("ignore invalid rules with invalid schema", () => {
-  expect(() => new Engine({}, [])).toThrow();
-  expect(() => new Engine({}, "schema")).toThrow();
+test("ignore empty rules with invalid schema", () => {
+  expect(() => new Engine(invalidRules, [])).toThrow();
+  expect(() => new Engine(invalidRules, "schema")).toThrow();
 });
 
 test("initialize with invalid rules", () => {

test/validation.test.js

@@ -150,7 +150,7 @@ test("invalid field or", () => {
 
   expect(() => predicatesFromRule(invalidFieldOr[0].firstName)).toThrow();
   expect(testInProd(() => predicatesFromRule(invalidFieldOr[0].firstName))).toEqual([]);
-  expect(() => validate(invalidFieldOr, schema)).toThrow();
+  expect(() => validatePredicates(invalidFieldOr, schema)).toThrow();
 });
 
 test("invalid field NOT or", () => {
@@ -165,7 +165,7 @@ test("invalid field NOT or", () => {
     },
   ]);
 
-  expect(() => validate(invalidFieldNotWithOr, schema)).toThrow();
+  expect(() => validatePredicates(invalidFieldNotWithOr, schema)).toThrow();
 });
 
 test("valid field or", () => {