Skip to content
This repository was archived by the owner on May 8, 2022. It is now read-only.

Store buffer in memory (instead of writing to disk) #30

Closed
joshjryan opened this issue Apr 23, 2022 · 5 comments
Closed

Store buffer in memory (instead of writing to disk) #30

joshjryan opened this issue Apr 23, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@joshjryan
Copy link

Is your feature request related to a problem? Please describe.
My clients buffer more often than I'd expect, when using the xTeVe (and ffmpeg and VLC) buffer. I'm not exactly sure what's causing it, but looking at how much is written and read from disk is interesting.

Describe the solution you'd like
Might it be better to store the buffer in memory, instead of all the writes/reads to the temp directory?

Describe alternatives you've considered
N/A

Additional context
I just want to get some input on this thought. Feel free to let me know what you think.

@SCP002 SCP002 added the enhancement New feature or request label Apr 24, 2022
@SCP002
Copy link
Owner

SCP002 commented Apr 24, 2022

It would be better to determine the root cause, but until we figure it out ... yet another checkbox will never hurt 😉

@joshjryan
Copy link
Author

@SCP002, dude! do you not have a day job? I hadn't even had time to look at how this should be implemented, and you already did it.
I'll pull down your changes and build it to give it a go.

@SCP002
Copy link
Owner

SCP002 commented Apr 26, 2022

@joshjryan Kind of 😅 Will make a new release in, <= 2 hours from now, just need a small break 🙂

@joshjryan
Copy link
Author

I just pulled your changes down and built it...I'll keep an eye on memory usage to see if anything is leaking.

@SCP002
Copy link
Owner

SCP002 commented Apr 26, 2022

@joshjryan Here is the "official" 🙃 build ready already.
P.S: Hope you don't have any unusual operation systems to try to run it at, because this time it built only for, basically, linux x64 and windows x64. Will try to fix it too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants