SS13-Source-Archive
diff --git a/‎.github/CONTRIBUTING.md
+98 b/‎.github/CONTRIBUTING.md
+98
diff --git a/‎.github/RUNNING_A_SERVER.md
+56 b/‎.github/RUNNING_A_SERVER.md
+56
diff --git a/‎.github/workflows/gbp_collect.yml
+1 b/‎.github/workflows/gbp_collect.yml
+1
diff --git a/‎.vscode/settings.json
+3-6 b/‎.vscode/settings.json
+3-6
diff --git a/‎_maps/RandomRuins/AnywhereRuins/golem_ship.dmm
+12-28 b/‎_maps/RandomRuins/AnywhereRuins/golem_ship.dmm
+12-28
@@ -547,6 +547,103 @@ for (var/month in 1 to 12)
 for (var/i in reagents)
 ```
 
+### Icons are for image manipulation and defining an obj's `.icon` var, appearances are for everything else.
+BYOND will allow you to use a raw icon file or even an icon datum for underlays, overlays, and what not (you can even use strings to refer to an icon state on the current icon). The issue is these get converted by BYOND to appearances on every overlay insert or removal involving them, and this process requires inserting the new appearance into the global list of appearances, and informing clients about them.
+
+Converting them yourself to appearances and storing this converted value will ensure this process only has to happen once for the lifetime of the round. Helper functions exist to do most of the work for you.
+
+
+Bad:
+```dm
+/obj/machine/update_overlays(blah)
+	if (stat & broken)
+		add_overlay(icon(broken_icon))  //this icon gets created, passed to byond, converted to an appearance, then deleted.
+		return
+	if (is_on)
+		add_overlay("on") //also bad, the converstion to an appearance still has to happen
+	else
+		add_overlay(iconstate2appearance(icon, "off")) //this might seem alright, but not storing the value just moves the repeated appearance generation to this proc rather then the core overlay management. It would only be acceptable (and to some degree perferred) if this overlay is only ever added once (like in init code)
+```
+
+Good:
+```dm
+/obj/machine/update_overlays(var/blah)
+	var/static/on_overlay
+	var/static/off_overlay
+	var/static/broken_overlay
+	if(isnull(on_overlay)) //static vars initialize with global variables, meaning src is null and this won't pass integration tests unless you check.
+		on_overlay = iconstate2appearance(icon, "on")
+		off_overlay = iconstate2appearance(icon, "off")
+		broken_overlay = icon2appearance(broken_icon)
+	if (stat & broken)
+		add_overlay(broken_overlay) 
+		return
+	if (is_on)
+		add_overlay(on_overlay)
+	else
+		add_overlay(off_overlay)
+	...
+```
+
+Note: images are appearances with extra steps, and don't incur the overhead in conversion.
+
+
+### Do not abuse associated lists.
+Associated lists that could instead be variables or statically defined number indexed lists will use more memory, as associated lists have a 24 bytes per item overhead (vs 8 for lists and most vars), and are slower to search compared to static/global variables and lists with known indexes.
+
+
+Bad:
+```dm
+/obj/machine/update_overlays(var/blah)
+	var/static/our_overlays
+	if(isnull(our_overlays)
+		our_overlays = list("on" = iconstate2appearance(overlay_icon, "on"), "off" = iconstate2appearance(overlay_icon, "off"), "broken" = iconstate2appearance(overlay_icon, "broken"))
+	if (stat & broken)
+		add_overlay(our_overlays["broken"]) 
+		return
+	...
+```
+
+Good:
+```dm
+#define OUR_ON_OVERLAY 1
+#define OUR_OFF_OVERLAY 2
+#define OUR_BROKEN_OVERLAY 3
+/obj/machine/update_overlays(var/blah
+	var/static/our_overlays
+	if(isnull(our_overlays)
+		our_overlays = list(iconstate2appearance(overlay_icon, "on"), iconstate2appearance(overlay_icon, "off"), iconstate2appearance(overlay_icon, "broken"))
+	if (stat & broken)
+		add_overlay(our_overlays[OUR_BROKEN_OVERLAY])
+		return
+	...
+
+#undef OUR_ON_OVERLAY
+#undef OUR_OFF_OVERLAY
+#undef OUR_BROKEN_OVERLAY
+```
+Storing these in a flat (non-associated) list saves on memory, and using defines to reference locations in the list saves CPU time searching the list.
+
+Also good:
+```dm
+/obj/machine/update_overlays(var/blah)
+	var/static/on_overlay
+	var/static/off_overlay
+	var/static/broken_overlay
+	if(isnull(on_overlay))
+		on_overlay = iconstate2appearance(overlay_icon, "on")
+		off_overlay = iconstate2appearance(overlay_icon, "off")
+		broken_overlay = iconstate2appearance(overlay_icon, "broken")
+	if (stat & broken)
+		add_overlay(broken_overlay)
+		return
+	...
+```
+Proc variables, static variables, and global variables are resolved at compile time, so the above is equivalent to the second example, but is easier to read, and avoids the need to store a list.
+
+Note: While there has historically been a strong impulse to use associated lists for caching of computed values, this is the easy way out and leaves a lot of hidden overhead. Please keep this in mind when designing core/root systems that are intended for use by other code/coders. It's normally better for consumers of such systems to handle their own caching using vars and number indexed lists, than for you to do it using associated lists.
+
+
 ### Other Notes
 * Code should be modular where possible; if you are working on a new addition, then strongly consider putting it in its own file unless it makes sense to put it with similar ones (i.e. a new tool would go in the "tools.dm" file)
 
@@ -564,6 +661,7 @@ for (var/i in reagents)
 
 * The dlls section of tgs3.json is not designed for dlls that are purely `call()()`ed since those handles are closed between world reboots. Only put in dlls that may have to exist between world reboots.
 
+
 #### Enforced not enforced
 The following coding styles are not only not enforced at all, but are generally frowned upon to change for little to no reason:
 
 
@@ -89,6 +89,62 @@ Web delivery of game resources makes it quicker for players to join and reduces
     * If you keep up to date with /tg/ you could reuse /tg/'s rsc cdn at http://tgstation13.download/byond/tgstation.zip. Otherwise you can use cdn services like CDN77 or cloudflare (requires adding a page rule to enable caching of the zip), or roll your own cdn using route 53 and vps providers.
 	* Regardless even offloading the rsc to a website without a CDN will be a massive improvement over the in game system for transferring files.
 
+### All In One Amazon Web Services Hosting and Content delivery network.
+**Important Note**
+It is very Importat to note that since AWS is all highly integrated its "easier" than some solutions. However the Price to ***Performance Ratio is terrible***.
+
+/tg/ Using around 7TB of bandwidth a month. These costs add up. So AWS is probly only a solution for low to mid pop servers
+
+**Please use [AWS Cost Estimator](https://calculator.s3.amazonaws.com/index.html) to determine if this solution is right for you.**
+
+This also may not be the best AWS set up but it works.
+
+This guide is also assuming you are setting up a production server and not a server that you bring up and down on weekends.
+It is highly recommended to reference AWS support documentation while reading this guide. This guide is not a How to AWS.
+
+**Required AWS Services**
+1. Elastic Computer 2 (EC2)
+	* What size and class is up to you but 4GB of RAM is a minimum.
+1. Route53
+	* Domain registration and assigning "Elastic" IP addresses to said web addresses
+1. S3
+	* This will be your storage point and distrobution point for your .RSC file
+1. Identity and Access Management (IAM)
+	* Required for EC2 to S3 file transfers
+
+**Required Software**
+1. Microsoft Windows
+1. MariaDB
+1. TGS4
+1. Notepad++ or other code editor for writing batch scripts
+1. AWS Command Line V2
+
+**Instructions**
+1. After you go through setting up an AWS account you will need to create an IAM role and an IAM user. the IAM user will be made for debug testing. The IAM role will be used as an internal credential for the EC2 instance to talk with S3
+	* The role and user creation are almost identical. give them names, select programatic access, then you will click atatych existing policey, Here you can use admin access or S3 full access. both can be found via search. the difference for roles is that you will on the first step declare it for use with EC2 and this one will need full admin access
+1. Create your Amazon EC2 instance. There will be a config option asking for an IAM role. use the IAM role created in the previous step.
+	* A blank Windows Server is recommended
+	* You will also need to define a security policey. 3 are recommended. a Remote Desktop Protocol Policey, a Maria DB Policey, and an SS13 policey. the Latter will use the port(s) of your dream demon settings. Make sure the SS13 policey whitelists all IP addresses.
+1. Creat your S3 bucket. this is a very simple process. only thing you need to edit is making the bucket public and making sure its in the same region as your EC2 instance.
+1. In the EC2 control panel, go to Elastic IP's. get one and assign it to your EC2 instance. This will result in the server IP address not changing and is required for joining the game via url instead of ip address
+1. In Route 53 you will register a domain name. The you will create a hosted zone and tell your domain to use the IP address you used for your EC2 instance.
+1. Install the required software
+	* AWSCL2 you will need to run the configuration using the IAM User you created above.
+	* TGS4: Make sure the TGS4 scripts from /tools/ are installed per tgs 4 instructions after you have set up your repository and done your first fetch. You will need to Also install a batch file similar to what i have provided into the event scripts folder. You can manually run the batch file to test connection to your S3 bucket.
+	* Copy `compile_options.dm` into code overrides preserving the directory structure and altering the code as mentioned in the above CDN instructions.
+	* Filename: DeploymentComplete.bat
+```Batch
+@echo off
+cd "C:\Program Files\Amazon\AWSCLIV2"
+aws s3 cp "C:\Instance_Path\Game\Live\tgstation.rsc" s3://BucketName/tgstation.rsc --acl public-read
+```
+
+7. In your TGS4's instance's static config files edit resources.txt to point to the resource file uploaded by the batch file. it should resemble `http://BucketName.s3.AWSRegion.amazonaws.com/tgstation.rsc` You can get this url from the S3 object management page after its been uploaded for the first time. *Make sure you do not use use HTTPS. Byond can not do encryption*
+7. Tell TGS4 to fetch and deploy. If everything goes according to plan, your server will be compiled and the resource uploaded automatically to amazon S3. You can verify that by checking on the file your bucket via aws web management.
+7. Test your client side connection.
+	* Tell TGS4 to run the compiled server
+	* Attempt to log in. AWS has a stupid fast transfer speed. you should download client side data faster than you can recognize it happened.
+
 ## IRC BOT SETUP
 
 Included in the repository is a python3 compatible IRC bot capable of relaying adminhelps to a specified
 
@@ -3,6 +3,7 @@ name: GBP Collection
 on:
   schedule:
   - cron: "20 * * * *"
+  workflow_dispatch:
 jobs:
   gbp_collection:
     runs-on: ubuntu-latest
 
@@ -12,12 +12,9 @@
 	"editor.codeActionsOnSave": {
 		"source.fixAll.eslint": true
 	},
-	"workbench.editorAssociations": [
-		{
-			"filenamePattern": "*.dmi",
-			"viewType": "imagePreview.previewEditor"
-		}
-	],
+	"workbench.editorAssociations": {
+		"*.dmi": "imagePreview.previewEditor"
+	},
 	"files.eol": "\n",
 	"gitlens.advanced.blame.customArguments": ["-w"],
 	"tgstationTestExplorer.project.resultsType": "json",
 
@@ -92,19 +92,15 @@
 	dir = 4;
 	name = "shrine of the liberator"
 	},
-/obj/machinery/light{
-	dir = 8
-	},
+/obj/machinery/light/directional/west,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "r" = (
 /obj/machinery/computer/shuttle,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "t" = (
-/obj/structure/extinguisher_cabinet{
-	pixel_y = 30
-	},
+/obj/structure/extinguisher_cabinet/directional/north,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "u" = (
@@ -143,9 +139,7 @@
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "z" = (
-/obj/structure/extinguisher_cabinet{
-	pixel_y = -30
-	},
+/obj/structure/extinguisher_cabinet/directional/south,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "A" = (
@@ -161,7 +155,7 @@
 /obj/item/storage/firstaid/fire,
 /obj/structure/table/wood,
 /obj/item/storage/firstaid/fire,
-/obj/machinery/light,
+/obj/machinery/light/directional/south,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "C" = (
@@ -198,7 +192,7 @@
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "I" = (
-/obj/machinery/light/small,
+/obj/machinery/light/small/directional/south,
 /turf/open/floor/plating,
 /area/ruin/powered/golem_ship)
 "K" = (
@@ -210,32 +204,24 @@
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "L" = (
-/obj/machinery/light/small{
-	dir = 1
-	},
+/obj/machinery/light/small/directional/north,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "M" = (
 /obj/effect/mob_spawn/human/golem/adamantine,
-/obj/machinery/light/small{
-	dir = 1
-	},
+/obj/machinery/light/small/directional/north,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "N" = (
-/obj/machinery/light{
-	dir = 1
-	},
+/obj/machinery/light/directional/north,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "O" = (
-/obj/machinery/light{
-	dir = 8
-	},
+/obj/machinery/light/directional/west,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "Q" = (
-/obj/machinery/light/small,
+/obj/machinery/light/small/directional/south,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "T" = (
@@ -245,13 +231,11 @@
 /area/ruin/powered/golem_ship)
 "U" = (
 /obj/effect/mob_spawn/human/golem/adamantine,
-/obj/machinery/light/small,
+/obj/machinery/light/small/directional/south,
 /turf/open/floor/mineral/titanium/purple,
 /area/ruin/powered/golem_ship)
 "V" = (
-/obj/machinery/light/small{
-	dir = 1
-	},
+/obj/machinery/light/small/directional/north,
 /turf/open/floor/plating,
 /area/ruin/powered/golem_ship)
 "Y" = (