From dc3efc99a034a91470aa0c61b39688461cef9b30 Mon Sep 17 00:00:00 2001
From: cclhsu <clark.hsu@suse.com>
Date: Fri, 21 Feb 2020 15:22:45 +0800
Subject: [PATCH] apply suggestions for update addon using yaml (#671)

apply suggestions from code review for update addon using yaml (#671)

Signed-off-by: cclhsu <clark.hsu@suse.com>
---
 .gitignore                    |  1 +
 adoc/admin-security-rbac.adoc | 15 +++++----------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/.gitignore b/.gitignore
index d3895a00a..574701792 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,3 +7,4 @@ build/
 .directory
 .DS_Store
 .DS_Store?
+.vscode/
diff --git a/adoc/admin-security-rbac.adoc b/adoc/admin-security-rbac.adoc
index 31fb33964..19402e6f9 100644
--- a/adoc/admin-security-rbac.adoc
+++ b/adoc/admin-security-rbac.adoc
@@ -93,11 +93,7 @@ kubectl create rolebinding admin --clusterrole=admin --user=<USER_1> --user=<USE
 Administrators can update the authentication connector settings after {productname}
 deployment as follows:
 
-. Run the following `kubectl` command to access Dex ConfigMap:
-+
-----
-kubectl --namespace=kube-system edit configmap oidc-dex-config
-----
+. Edit and save Dex addon YAML in `~/clusters/<CLUSTER_NAME>/addons/dex/dex.yml`
 +
 . Adapt ConfigMap by adding LDAP configuration to the connector section.
 For detailed configuration of the LDAP connector, refer to Dex documentation:
@@ -140,15 +136,14 @@ Besides the LDAP connector you can also set up other connectors.
 For additional connectors, refer to the available connector configurations in the Dex repository:
 https://github.com/dexidp/dex/tree/v2.16.0/Documentation/connectors.
 +
-. Save and exit Dex ConfigMap by typing `:wq` in the terminal.
-+
-. Restart Dex and Gangway by running:
+. Apply changes:
 +
 ----
-kubectl --namespace=kube-system delete pod -l app=oidc-dex
-kubectl --namespace=kube-system delete pod -l app=oidc-gangway
+kubectl apply -f ~/clusters/<CLUSTER_NAME>/addons/dex/dex.yml
 ----
 
+NOTE: Before any add-on upgrade, please backup any runtime configuration changes, then restore the modification back after upgraded. It is known limitation.
+
 [[_sec.admin.security.rbac.apply]]
 === User Access