Skip to content

Commit fe242a2

Browse files
committed
feat #OBS-I568 : set datasource as dataset_id if v1
1 parent 84874ab commit fe242a2

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

api-service/src/services/DatasetService.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -344,14 +344,17 @@ class DatasetService {
344344

345345
private updateDruidDataSource = async (draftDataset: Record<string, any>, transaction: Transaction, existingDatasource: Record<string, any>) => {
346346

347-
const { created_by, updated_by } = draftDataset;
347+
const { created_by, updated_by, dataset_id, api_version } = draftDataset;
348348
const allFields = await tableGenerator.getAllFields(draftDataset, "druid");
349349
const ingestionSpec = tableGenerator.getDruidIngestionSpec(draftDataset, allFields, existingDatasource.datasource_ref);
350350
let draftDatasource = existingDatasource
351351
_.set(draftDatasource, "ingestion_spec", ingestionSpec)
352352
_.set(draftDatasource, "created_by", created_by);
353353
_.set(draftDatasource, "updated_by", updated_by);
354354
_.set(draftDatasource, "type", "druid");
355+
if (api_version === "v1") {
356+
_.set(draftDatasource, "datasource", dataset_id)
357+
}
355358
await DatasourceDraft.upsert(draftDatasource, { transaction })
356359
}
357360

command-service/src/command/db_command.py

+2
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ def _insert_datasource_record(self, dataset_id, draft_dataset_id):
190190
json.dumps(draft_datasource.metadata).replace("'", "''"),
191191

192192
draft_datasource.datasource_ref,
193+
draft_datasource.datasource,
193194
json.dumps(draft_datasource.ingestion_spec),
194195
draft_datasource.type,
195196
json.dumps(draft_datasource.retention_period).replace("'", "''"),
@@ -227,6 +228,7 @@ def _insert_datasource_record(self, dataset_id, draft_dataset_id):
227228
)
228229
ON CONFLICT (id) DO UPDATE
229230
SET datasource_ref = %s,
231+
datasource = %s,
230232
ingestion_spec = %s,
231233
type = %s,
232234
retention_period = %s,

0 commit comments

Comments
 (0)