Fixed issue with asprintf

Author: Peter Karlsson

src/Common/Timecode.cpp

@@ -20,15 +20,14 @@ QString Timecode::fromTime(double time, double fps, bool useDropFrameNotation)
     int seconds;
     int frames;
 
-    QString smpteFormat;
-
     hour = (int)(time / 3600);
     minutes = (int)((time - hour * 3600) / 60);
     seconds = (int)(time - hour * 3600 - minutes * 60);
     frames = (int)((time - hour * 3600 - minutes * 60 - seconds) * fps);
 
-    if (useDropFrameNotation)
-        return smpteFormat.asprintf("%02d:%02d:%02d.%02d", hour, minutes, seconds, frames);
-    else
-        return smpteFormat.asprintf("%02d:%02d:%02d:%02d", hour, minutes, seconds, frames);
+    return QString("%1%2%3%4%5").arg(hour, 2, 16)
+                                .arg(minutes, 2, 16)
+                                .arg(seconds, 2, 16)
+                                .arg(useDropFrameNotation ? "." : ":")
+                                .arg(frames, 2, 16);
 }

src/Core/Commands/SolidColorCommand.cpp

@@ -28,8 +28,10 @@ const QString SolidColorCommand::getPremultipliedColor() const
     green = (green * alpha) / 255;
     blue = (blue * alpha) / 255;
 
-    QString color;
-    return color.asprintf("#%02x%02x%02x%02x", alpha, red, green, blue);
+    return QString("#%1%2%3%4").arg(alpha, 2, 16)
+                               .arg(red, 2, 16)
+                               .arg(green, 2, 16)
+                               .arg(blue, 2, 16);
 }
 
 const QString& SolidColorCommand::getTransition() const

src/Panasonic/PtzDevice.cpp

@@ -17,7 +17,7 @@ void PtzDevice::selectPreset(const QString& address, int preset)
     QUrl request(QString("http://%1/cgi-bin/aw_ptz").arg(address));
 
     QUrlQuery query;
-    query.addQueryItem("cmd", QString("#R%1").arg(QString(preset).asprintf("%02d", preset)));
+    query.addQueryItem("cmd", QString("#R%1").arg(preset, 2, 10));
     query.addQueryItem("res", "1");
 
     request.setQuery(query);

src/Widgets/Inspector/InspectorSolidColorWidget.cpp

@@ -123,11 +123,12 @@ void InspectorSolidColorWidget::colorDialogClicked()
 
     if (dialog.exec() == QDialog::Accepted)
     {
-        QString color;
-        color.asprintf("#%02x%02x%02x%02x", dialog.selectedColor().alpha(), dialog.selectedColor().red(),
-                       dialog.selectedColor().green(), dialog.selectedColor().blue());
+        QString color = QString("#%1%2%3%4").arg(dialog.selectedColor().alpha(), 2, 16)
+                                            .arg(dialog.selectedColor().red(), 2, 16)
+                                            .arg(dialog.selectedColor().green(), 2, 16)
+                                            .arg(dialog.selectedColor().blue(), 2, 16);
 
-        this->lineEditColor->setText(color);
+        this->lineEditColor->setText(color.toUpper());
     }
 }
 

src/Widgets/Rundown/RundownTreeBaseWidget.cpp

@@ -310,18 +310,18 @@ void RundownTreeBaseWidget::removeAllItems()
         AbstractRundownWidget* widget = dynamic_cast<AbstractRundownWidget*>(QTreeWidget::itemWidget(item, 0));
         if (widget->isGroup())
         {
-            for (int i = item->childCount() - 1; i >= 0; i--)
+            for (int j = item->childCount() - 1; j >= 0; j--)
             {
-                QWidget* childWidget = QTreeWidget::itemWidget(item->child(i), 0);
+                QWidget* childWidget = QTreeWidget::itemWidget(item->child(j), 0);
 
                 // Remove our items from the auto play queue if it exists.
-                EventManager::getInstance().fireRemoveItemFromAutoPlayQueueEvent(RemoveItemFromAutoPlayQueueEvent(item->child(i)));
+                EventManager::getInstance().fireRemoveItemFromAutoPlayQueueEvent(RemoveItemFromAutoPlayQueueEvent(item->child(j)));
 
                 // Clear current playing item.
-                EventManager::getInstance().fireClearCurrentPlayingItemEvent(ClearCurrentPlayingItemEvent(item->child(i)));
+                EventManager::getInstance().fireClearCurrentPlayingItemEvent(ClearCurrentPlayingItemEvent(item->child(j)));
 
                 delete childWidget;
-                delete item->child(i);
+                delete item->child(j);
             }
         }