move rescue for TypeError from conditional into method body

I'm moving the rescue statement from the coditional into the method body
of constant_name_from_node. If we look at the code we notice that we
have a couple of constant_name method calls that can throw this
exception. By changing the scope we are able to prevent unintended
TypeErrors to crash the program.

-        begin
-          Node.constant_name(node)
-        rescue Node::TypeError
-          nil
-        end
+        Node.constant_name(node)
       end
+    rescue Node::TypeError
+      nil

Author: doodzik

lib/packwerk/const_node_inspector.rb

@@ -17,12 +17,10 @@ def constant_name_from_node(node, ancestors:)
       if constant_in_module_or_class_definition?(node, ancestors: ancestors)
         fully_qualify_constant(node, ancestors: ancestors)
       else
-        begin
-          Node.constant_name(node)
-        rescue Node::TypeError
-          nil
-        end
+        Node.constant_name(node)
       end
+    rescue Node::TypeError
+      nil
     end
 
     private