Merge pull request #38 from tonymarklove/ignore-vendor-package-yml

Author: wildmaples

lib/packwerk/application_validator.rb

@@ -331,7 +331,7 @@ def package_glob
     end
 
     def package_manifests(glob_pattern)
-      Dir.glob(File.join(glob_pattern, Packwerk::PackageSet::PACKAGE_CONFIG_FILENAME)).map { |f| File.realpath(f) }
+      PackageSet.package_paths(@configuration.root_path, glob_pattern).map(&:to_s)
     end
 
     def relative_paths(paths)

lib/packwerk/package_set.rb

@@ -25,13 +25,15 @@ def load_all_from(root_path, package_pathspec: nil)
         new(packages)
       end
 
-      private
-
       def package_paths(root_path, package_pathspec)
+        bundle_path_match = Bundler.bundle_path.join("**").to_s
+
         Dir.glob(File.join(root_path, package_pathspec, PACKAGE_CONFIG_FILENAME))
-          .map! { |path| Pathname.new(path) }
+          .map { |path| Pathname.new(path) }.reject { |path| path.realpath.fnmatch(bundle_path_match) }
       end
 
+      private
+
       def create_root_package_if_none_in(packages)
         return if packages.any?(&:root?)
         packages << Package.new(name: Package::ROOT_PACKAGE_NAME, config: nil)

lib/packwerk/run_context.rb

@@ -39,6 +39,7 @@ def from_configuration(configuration, reference_lister: nil)
         new(
           root_path: configuration.root_path,
           load_paths: configuration.load_paths,
+          package_paths: configuration.package_paths,
           inflector: ActiveSupport::Inflector,
           custom_associations: configuration.custom_associations,
           reference_lister: default_reference_lister,

test/fixtures/skeleton/vendor/cache/gems/example/package.yml

@@ -113,7 +113,12 @@ class CliTest < Minitest::Test
 
     test "#execute_command with init subcommand runs application validation generator for non-Rails app" do
       string_io = StringIO.new
-      configuration = stub(root_path: @temp_dir, load_paths: ["path"], custom_associations: ["cached_belongs_to"])
+      configuration = stub(
+        root_path: @temp_dir,
+        load_paths: ["path"],
+        package_paths: "**/",
+        custom_associations: ["cached_belongs_to"]
+      )
       cli = ::Packwerk::Cli.new(configuration: configuration, out: string_io)
 
       Packwerk::Generators::ApplicationValidation.expects(:generate).returns(true)
@@ -125,7 +130,12 @@ class CliTest < Minitest::Test
 
     test "#execute_command with init subcommand runs application validation generator, fails and prints error" do
       string_io = StringIO.new
-      configuration = stub(root_path: @temp_dir, load_paths: ["path"], custom_associations: ["cached_belongs_to"])
+      configuration = stub(
+        root_path: @temp_dir,
+        load_paths: ["path"],
+        package_paths: "**/",
+        custom_associations: ["cached_belongs_to"]
+      )
       cli = ::Packwerk::Cli.new(configuration: configuration, out: string_io)
 
       Packwerk::Generators::ApplicationValidation.expects(:generate).returns(false)

test/unit/cli_test.rb

@@ -31,5 +31,16 @@ class PackageSetTest < Minitest::Test
     test "#fetch returns nil for unknown package name" do
       assert_nil(@package_set.fetch("components/unknown"))
     end
+
+    test ".package_paths excludes paths inside the gem directory" do
+      vendor_package_path = Pathname.new("test/fixtures/skeleton/vendor/cache/gems/example/package.yml")
+
+      package_paths = PackageSet.package_paths("test/fixtures/skeleton", "**")
+      assert_includes(package_paths, vendor_package_path)
+
+      Bundler.expects(:bundle_path).returns(Rails.root.join("vendor/cache/gems"))
+      package_paths = PackageSet.package_paths("test/fixtures/skeleton", "**")
+      refute_includes(package_paths, vendor_package_path)
+    end
   end
 end