Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update command should remove deprecated_references.yml file when all violations are removed #49

Closed
wildmaples opened this issue Oct 23, 2020 · 2 comments
Closed

Update command should remove deprecated_references.yml file when all violations are removed #49

wildmaples opened this issue Oct 23, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@wildmaples
Copy link
Contributor

When all the violations are resolved from a package, packwerk update does not delete the file, leaving the file stale. packwerk update should somehow be able to remove stale files completely.
@wildmaples wildmaples added the bug Something isn't working label Oct 23, 2020
@wildmaples wildmaples changed the title Update command should deprecated_references.yml file when violations are gone Update command should remove deprecated_references.yml file when all violations are removed Oct 23, 2020
@wildmaples wildmaples added enhancement New feature or request and removed bug Something isn't working labels Oct 23, 2020
@wildmaples wildmaples mentioned this issue Oct 23, 2020
Closed
@mclark mclark mentioned this issue Apr 20, 2022
Closed
7 tasks
@rafaelfranca
Copy link
Member

TODO:

@alexevanczuk
Copy link
Contributor

Fixed by #249 and #272, will be released in 3.x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete deprecated references files when empty github/packwerk
3 participants
@rafaelfranca @alexevanczuk @wildmaples