Added icons package to eslint-ts config and fixed some eslint errors

Co-authored-by: Aaron Cassanova <aaron.cassanova@shopify.com>

Author: Yuraima Estevez

.eslintrc.js

@@ -17,7 +17,9 @@ module.exports = {
     tsconfigRootDir: __dirname,
     project: [
       './tsconfig.eslint.json',
-      ...packages.map((pkg) => `./${pkg}/tsconfig.json`),
+      ...packages
+        .filter((pkg) => pkg !== 'polaris-icons')
+        .map((pkg) => `./${pkg}/tsconfig.json`),
     ],
   },
   settings: {

polaris-icons/package.json

@@ -21,7 +21,8 @@
     "clean": "rm -rf .turbo node_modules dist",
     "dev": "rollup -c -w",
     "test": "jest",
-    "optimize": "svgo -f icons"
+    "optimize": "svgo -f icons",
+    "lint": "TIMING=1 eslint --cache ."
   },
   "exports": {
     ".": {

polaris-icons/tests/validate-svg-content.test.js

@@ -1,6 +1,7 @@
 const fs = require('fs');
 const path = require('path');
 
+// eslint-disable-next-line import/no-extraneous-dependencies
 const svgo = require('svgo');
 const globby = require('globby');
 const unified = require('unified');
@@ -9,7 +10,7 @@ const {select, selectAll} = require('hast-util-select');
 
 const svgoConfig = require('../svgo.config');
 
-const nameRegex = /(?<=)(Major|Minor)(?=\.svg)/;
+// const nameRegex = /(?<=)(Major|Minor)(?=\.svg)/;
 
 const allIconFiles = globby
   .sync(path.resolve(__dirname, '../icons/*.svg'))
@@ -35,7 +36,7 @@ allIconFiles.forEach(
     optimizedSource,
     iconAst,
     expectedViewbox,
-    expectedFillColors,
+    // expectedFillColors,
   }) => {
     describe(`SVG Contents: packages/${iconPath}`, () => {
       it(`is optimized`, () => {

tsconfig.eslint.json

@@ -1,7 +1,6 @@
 {
   // Root config used to specify which TS files to lint
   // https://typescript-eslint.io/docs/linting/monorepo/#one-root-tsconfigjson
-
   "compilerOptions": {
     // Ensures this config is not used for a build
     "noEmit": true
@@ -14,6 +13,7 @@
     "polaris-react",
     "polaris-tokens",
     "polaris.shopify.com",
-    "stylelint-polaris"
+    "stylelint-polaris",
+    "polaris-icons"
   ]
 }