Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button - external not parsed correctly #11291

Closed
owlyowl opened this issue Dec 7, 2023 · 2 comments
Closed

Button - external not parsed correctly #11291

owlyowl opened this issue Dec 7, 2023 · 2 comments

Comments

@owlyowl
Copy link

owlyowl commented Dec 7, 2023

Issue summary

When trying to use external in the Remix App Template with a Button the typing is correct and external is a boolean.

When rendering in the browser it renders the link but target isn't present and the url property still is.
<a data-polaris-unstyled="true" class="Polaris-Button Polaris-Button--primary" url="https://www.shopify.com/" href="https://www.shopify.com/"><span class="Polaris-Button__Content"><span class="Polaris-Button__Text">Hi!</span></span></a>

Expected behavior

Button should open URL in an external window and markup should render correctly

Actual behavior

image
image

Steps to reproduce the problem

  1. Create a Button like so <Button variant="primary" url={myUrl} external>Hi!</Button>

Specifications

  • Are you using the React components? (Y): Yes
@shopify/polaris: ^12.0.0 => 12.0.0
react: ^18.2.0 => 18.2.0
react-dom: ^18.2.0 => 18.2.0
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

@axis80
Copy link

axis80 commented Mar 11, 2025

This issue is still present in Polaris 13.9.3. Can this issue be reopened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants