version 3.6 > 3.7, fix to antennas idle EC consumption

Author: gotmachine

CHANGELOG.md

@@ -1,3 +1,12 @@
+## v3.7 for all versions of KSP from 1.5.0 to 1.9.x
+
+ - 2020-02-21
+
+### Changes since the last release
+
+* Reverted antennas idle EC consumption to pre-3.6 levels : factor changed from 0.2 to 0.04
+* Removed logging calls from other threads
+
 ## v3.6 for all versions of KSP from 1.5.0 to 1.9.x
 
  - 2020-02-18

GameData/Kerbalism/Kerbalism.version

@@ -3,7 +3,7 @@
   "URL": "https://raw.githubusercontent.com/Kerbalism/Kerbalism/master/GameData/Kerbalism/Kerbalism.version",
   "DOWNLOAD": "https://github.com/Kerbalism/Kerbalism/releases",
   "CHANGE_LOG_URL": "https://github.com/Kerbalism/Kerbalism/blob/master/CHANGELOG.md",
-  "VERSION": {"MAJOR": 3, "MINOR": 6, "PATCH": 0, "BUILD": 0},
+  "VERSION": {"MAJOR": 3, "MINOR": 7, "PATCH": 0, "BUILD": 0},
   "KSP_VERSION": {"MAJOR": 1, "MINOR": 8, "PATCH": 0},
   "KSP_VERSION_MIN": {"MAJOR": 1, "MINOR": 5, "PATCH": 0},
   "KSP_VERSION_MAX": {"MAJOR": 1, "MINOR": 9, "PATCH": 9}

GameData/Kerbalism/VersionConfig.xml

@@ -14,7 +14,7 @@ The values defined here will be propagated to :
     Kerbalism major and minor version numbers 
     -->
 		<KerbalismVersionMajor>3</KerbalismVersionMajor>
-		<KerbalismVersionMinor>6</KerbalismVersionMinor>
+		<KerbalismVersionMinor>7</KerbalismVersionMinor>
     <!-- 
     Must match the `include=XXXX` of a KBinVersionConstant item, 
     used to determine the lowest and highest supported KSP version in the Kerbalism.version KSP-AVC file.

GameData/KerbalismConfig/Settings.cfg

@@ -22,13 +22,13 @@ Kerbalism
   ScienceDialog = true                // keep showing the stock science dialog
 
   // comms
-  DataRateDampingExponent = 6	      // stock commnet: exponent by which antenna bandwidth decreases with distance. higher value = lower bandwidth.
+  DataRateDampingExponent = 6         // stock commnet: exponent by which antenna bandwidth decreases with distance. higher value = lower bandwidth.
                                       // systems that have been scaled up or down should change this value accordingly
-  DataRateDampingExponentRT = 6	      // same as above, but for RemoteTech
+  DataRateDampingExponentRT = 6       // same as above, but for RemoteTech
   TransmitterActiveEcFactor = 1.5     // factor to the nominal ec consumption rate while antenna is active (transmitting)
-  TransmitterPassiveEcFactor = 0.2    // factor to the nominal ec consumption rate while antenna is inactive (idle/receiving)
+  TransmitterPassiveEcFactor = 0.04   // factor to the nominal ec consumption rate while antenna is inactive (idle/receiving)
   DataRateMinimumBitsPerSecond = 1.0  // as long as there is a control connection, the science data rate will never go below this.
-		
+    
 
   // reliability settings
   QualityScale = 4.0                  // scale applied to MTBF for high-quality components

README.md

@@ -8,7 +8,7 @@ Kerbalism is a mod for Kerbal Space Program that alters the game to add life sup
 
 ### Frequently Asked Questions: [FAQ]
 
-## Current version: 3.6
+## Current version: 3.7
 
 **What's new** : [New and Noteworthy]   
 **Download** : **[Github releases]** - **[CKAN]**  

src/Kerbalism/Properties/AssemblyInfo.cs

@@ -23,5 +23,5 @@
 //
 // You can specify all the values or you can use the default the Revision and
 // Build Numbers by using the '*' as shown below:
-[assembly: AssemblyVersion("3.6")]
-[assembly: AssemblyFileVersion("3.6")]
+[assembly: AssemblyVersion("3.7")]
+[assembly: AssemblyFileVersion("3.7")]

src/Kerbalism/System/Settings.cs

@@ -52,7 +52,7 @@ public static void Parse()
 			DataRateDampingExponentRT = Lib.ConfigValue(cfg, "DataRateDampingExponentRT", 6.0f);
 			DataRateSurfaceExperiment = Lib.ConfigValue(cfg, "DataRateSurfaceExperiment", 0.3f);
 			TransmitterActiveEcFactor = Lib.ConfigValue(cfg, "TransmitterActiveEcFactor", 1.5);
-			TransmitterPassiveEcFactor = Lib.ConfigValue(cfg, "TransmitterPassiveEcFactor", 0.2);
+			TransmitterPassiveEcFactor = Lib.ConfigValue(cfg, "TransmitterPassiveEcFactor", 0.04);
 
 			// science
 			ScienceDialog = Lib.ConfigValue(cfg, "ScienceDialog", true);

src/Kerbalism/UI/Planner/ResourceSimulator.cs

@@ -697,10 +697,10 @@ void Process_datatransmitter(ModuleDataTransmitter mdt)
 			switch (mdt.antennaType)
 			{
 				case AntennaType.INTERNAL:
-					Resource("ElectricCharge").Consume(mdt.DataResourceCost * mdt.DataRate, "communications (control)");
+					Resource("ElectricCharge").Consume(mdt.DataResourceCost * mdt.DataRate * Settings.TransmitterPassiveEcFactor, "communications (idle)");
 					break;
 				default:
-					Resource("ElectricCharge").Consume(mdt.DataResourceCost * mdt.DataRate, "communications (transmitting)");
+					Resource("ElectricCharge").Consume(mdt.DataResourceCost * mdt.DataRate * Settings.TransmitterActiveEcFactor, "communications (transmitting)");
 					break;
 			}
 		}

src/KerbalismBootstrap/Properties/AssemblyInfo.cs

@@ -31,5 +31,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("3.6.*")]
-[assembly: AssemblyFileVersion("3.6")]
+[assembly: AssemblyVersion("3.7.*")]
+[assembly: AssemblyFileVersion("3.7")]