Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Stage Node Handler Registration #157

Open
SIMULATAN opened this issue Feb 22, 2025 · 0 comments
Open

Multi-Stage Node Handler Registration #157

SIMULATAN opened this issue Feb 22, 2025 · 0 comments
Labels

Comments

@SIMULATAN
Copy link
Contributor

The current system is prone to race conditions. If the first Node Handler in the chain wants to use the Json dependency, it'll be created prematurely and lack the other Node Handler SerializersModules.

Instead, split the registration process into multiple stages. First, load all Koin modules. Only when all modules were loaded, create and register the NodeHandler. This should avoid these issues in the future?

Once that's done, check through the existing code to spot : Json = by inject() usages and try to replace them with eager injection. With this new system, this should also work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant