Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit a668054

Browse files
Drop Node.js 14 support and test against Node.js 20 on CI (#445)
1 parent e95d75d commit a668054

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

.cirrus.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,15 @@ qa_task:
5151
- build
5252
eks_container:
5353
matrix:
54-
- docker_arguments:
55-
NODE_VERSION: 14
56-
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
5754
- docker_arguments:
5855
NODE_VERSION: 16
5956
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
6057
- docker_arguments:
6158
NODE_VERSION: 18
6259
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
60+
- docker_arguments:
61+
NODE_VERSION: 20
62+
CIRRUS_AWS_ACCOUNT: ${CIRRUS_AWS_ACCOUNT}
6363
<<: *CONTAINER_DEFINITION
6464
cpu: 3
6565
memory: 8G

.cirrus/nodejs.Dockerfile

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ USER root
66
ARG NODE_VERSION=18
77
ARG SCANNER_VERSION=5.0.1.3006
88

9-
RUN apt-get update && apt-get install -y nodejs=${NODE_VERSION}.*
9+
RUN curl -fsSL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - \
10+
&& apt-get install -y nodejs=${NODE_VERSION}.*
1011

1112
RUN curl "https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${SCANNER_VERSION}.zip" -o /tmp/sonar-scanner.zip \
1213
&& unzip -d /opt /tmp/sonar-scanner.zip \

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Code Smells, or maintainability issues, are raised for places of code which migh
8181

8282
## Prerequisites
8383

84-
- Node.js (>=14.x).
84+
- Node.js (>=16.x).
8585
- ESLint 5.x, 6.x, 7.x or 8.x (peer dependency for the plugin).
8686

8787
## Usage

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
},
1717
"homepage": "https://github.com/SonarSource/eslint-plugin-sonarjs",
1818
"engines": {
19-
"node": ">=14"
19+
"node": ">=16"
2020
},
2121
"scripts": {
2222
"build": "rimraf lib && tsc -d -p tsconfig.json",

0 commit comments

Comments
 (0)