[DBUS] Missing Volume dbus property

[zack6849]

Hi!

I noticed you're missing the Volume property (and that's the only one that's missing that I saw)

One of the programs I use relies on that, I wrote up a quick shim to implement it and just return 0, and that worked

However, i was wondering about implementing the actual player volume

I did some poking around and found this:
https://github.com/ramsayleung/rspotify/blob/master/src/spotify/model/device.rs#L12

So it does seem that the volume /should/ be accessible from the context of a current playback context, I don't know rust well enough to implement it, I gave it a shot and got this, but it failed and returned 0 consistently.

I also think it should be f64, not u32, but was just trying to keep the type consistent with what rspotify used

I've attached a patch for what I tried.
0001-DBUS-Failed-attempt-at-implementing-volume-property.patch.txt

Thanks!

[mainrs]

Thanks for reporting this!

[zack6849]

Just curious, is this going to be implemented?

[mainrs]

I hope someone can step in and help me out on it. I do not have a lot of time right now (exams , ye 🥳). I am open for PRs though (always!). There are currently a bunch of unmerged ones but those are relatively big and I just don't have the time right now to skim over them in detail.

We are waiting mostly for a librespot merge to continue active, regular development. But dbus issues can be fixed in the meantime nonetheless :p

[slondr]

Implemented by #697