Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comet Targets produce undesireable directory layout for dataproducts #1185

Open
talister opened this issue Feb 21, 2025 · 0 comments
Open

Comet Targets produce undesireable directory layout for dataproducts #1185

talister opened this issue Feb 21, 2025 · 0 comments
Labels
bug Something isn't working Patch Party Collaborative effort mostly done as part of a patch party User Issue Raised by a user

Comments

@talister
Copy link
Contributor

Describe the bug
Since the slash in non-short period comet names e.g. "C/2021 G2 (ATLAS)" or "P/2024 O2" is preserved when creating a Target from the JPL Harvester, successful observations for these Targets contain an additional (unwanted) level of directory depth e.g.


(fomo311_venv) [tlister@tlister-thinkmate src]$ tree
.
├── data
│   └── ATLAS (C
│       └── 2021 G2)
│           └── LCO
│               ├── cpt1m012-fa06-20250213-0429-e00.fits.fz
│               ├── cpt1m012-fa06-20250213-0429-e00_tb.jpg
│               ├── cpt1m012-fa06-20250213-0429-e91.fits.fz
│               ├── cpt1m012-fa06-20250213-0429-e91_tb.jpg
│               ├── cpt1m012-fa06-20250213-0432-e00.fits.fz
│               ├── cpt1m012-fa06-20250213-0432-e00_tb.jpg
│               ├── cpt1m012-fa06-20250213-0432-e91.fits.fz
│               └── cpt1m012-fa06-20250213-0432-e91_tb.jpg

To Reproduce
Steps to reproduce the behavior:

  1. Obtain observational data on a comet target
  2. Save DataProducts
  3. Run e.g. tree on the directory of stored data
  4. See error

Expected behavior
Comet names should be sanitized to remove special characters, particularly the path separator, when they are being used to create directories for storing data

Desktop (please complete the following information):

  • OS: Rocky Linux 9.5
  • Browser: N/A
  • Version: 2.23.1
  • Python Version: 3.11.9
@talister talister added the bug Something isn't working label Feb 21, 2025
@github-project-automation github-project-automation bot moved this to Triage in TOM Toolkit Feb 21, 2025
@jchate6 jchate6 added the Patch Party Collaborative effort mostly done as part of a patch party label Feb 21, 2025
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Feb 21, 2025
@jchate6 jchate6 added the User Issue Raised by a user label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Patch Party Collaborative effort mostly done as part of a patch party User Issue Raised by a user
Projects
Status: Backlog
Development

No branches or pull requests

2 participants