Wrap Time.now in a stub class.

Author: bamnet

app/models/content.rb

@@ -29,9 +29,9 @@ def parent_id_cannot_be_this_content
   default_scope { where(:type => Content.subclasses.collect { |s| s.name }) unless Rails.env.development? }
 
   #Easily query for active, expired, or future content
-  scope :expired, where("end_time < :now", {:now => Time.now})
-  scope :future, where("start_time > :now", {:now => Time.now})
-  scope :active, where("(start_time IS NULL OR start_time < :now) AND (end_time IS NULL OR end_time > :now)", {:now => Time.now})
+  scope :expired, where("end_time < :now", {:now => Clock.time})
+  scope :future, where("start_time > :now", {:now => Clock.time})
+  scope :active, where("(start_time IS NULL OR start_time < :now) AND (end_time IS NULL OR end_time > :now)", {:now => Clock.time})
 
   #Scoped relations for feed approval states
   has_many :approved_feeds, :through => :submissions, :source => :feed, :conditions => {"submissions.moderation_flag" => true}
@@ -46,12 +46,12 @@ def parent_id_cannot_be_this_content
   # 1. Start date is before now, or nil.
   # 2. End date is after now, or nil.
   def is_active?
-    (start_time.nil? || start_time < Time.now) && (end_time.nil? || end_time > Time.now)
+    (start_time.nil? || start_time < Clock.time) && (end_time.nil? || end_time > Clock.time)
   end
 
   # Determine if content is expired based on its end time.
   def is_expired?
-    (end_time < Time.now)
+    (end_time < Clock.time)
   end
 
   # Setter for the start time.  If a hash is passed, convert that into a DateTime object and then a string.

app/views/contents/form_elements/_dates.html.erb

@@ -1,15 +1,15 @@
 <div class="clearfix datetime">
   <%= form.label :start_time %>
   <div class="input">
-		<%= form.text_field("start_time[date]", :id => "start_time_date", :maxlength => 20, :class => "datefield", 	:value=> (Time.now + ConcertoConfig[:start_date_offset].to_i.days).strftime("%m/%d/%Y"))%><a id="date_start" class="button date">&nbsp;</a>
+		<%= form.text_field("start_time[date]", :id => "start_time_date", :maxlength => 20, :class => "datefield", 	:value=> (Clock.time + ConcertoConfig[:start_date_offset].to_i.days).strftime("%m/%d/%Y"))%><a id="date_start" class="button date">&nbsp;</a>
 		<%= form.text_field("start_time[time]", :id => "start_time_time", :maxlength => 20, :class => "timefield", :value=>ConcertoConfig[:content_default_start_time])%><a id="time_start" class="button time">&nbsp;</a>
   </div>
 </div>
 
 <div class="clearfix datetime">
   <%= form.label :end_time %>
 	<div class="input">
-		<%= form.text_field("end_time[date]", :id => "end_time_date", :maxlength => 20, :class => "datefield", :value=>(Time.now + ConcertoConfig[:default_content_run_time].to_i.days + ConcertoConfig[:start_date_offset].to_i.days).strftime("%m/%d/%Y"))%><a id="date_end" class="button date">&nbsp;</a>
+		<%= form.text_field("end_time[date]", :id => "end_time_date", :maxlength => 20, :class => "datefield", :value=>(Clock.time + ConcertoConfig[:default_content_run_time].to_i.days + ConcertoConfig[:start_date_offset].to_i.days).strftime("%m/%d/%Y"))%><a id="date_end" class="button date">&nbsp;</a>
 		<%= form.text_field("end_time[time]", :id => "end_time_time", :maxlength => 20, :class => "timefield", :value=>ConcertoConfig[:content_default_end_time])%><a id="time_end" class="button time">&nbsp;</a>
 	</div>
 </div>

lib/clock.rb

@@ -0,0 +1,8 @@
+# Stub out a clock
+class Clock
+  # Wrapper around the current time.
+  # Makes mocking and debugging easier because you can freeze time.
+  def self.time
+    Time.now
+  end
+end