Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating values no longer works #25

Closed
HorieH opened this issue Jul 24, 2019 · 5 comments · Fixed by #26
Closed

Updating values no longer works #25

HorieH opened this issue Jul 24, 2019 · 5 comments · Fixed by #26

Comments

@HorieH
Copy link

HorieH commented Jul 24, 2019

When I updated the text by clicking the button, it stopped working.
This is my favorite library, so I would like you to fix it if possible.
For specifications, give up and use v0.5.4.

v0.5.4
sample1

v0.6.1
sample2

@TaylorBriggs
Copy link
Owner

Can you share a gist or code sample of how you're using the component?

When the button is clicked, does it change the children passed to Typewriter?

One final question, does this bug also exist in v0.6.0?

@HorieH
Copy link
Author

HorieH commented Jul 25, 2019

Can you share a gist or code sample of how you're using the component?

v0.5.4
https://snack.expo.io/@horieh/typewriterv054

v0.6.0
https://snack.expo.io/@horieh/typewriterv060

When the button is clicked, does it change the children passed to Typewriter?

Yes

One final question, does this bug also exist in v0.6.0?

Yes

@TaylorBriggs
Copy link
Owner

Thanks for the demo code, this helps a lot. I think I know what is causing the problem and will try to push a fix this weekend.

@TaylorBriggs
Copy link
Owner

Hi @HorieH, I published v0.6.2 which fixes this issue. Please let me know if you try it and the behavior is not what you expect. Thanks!

@HorieH
Copy link
Author

HorieH commented Jul 29, 2019

Perfect.👍 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants