Updated test_microsim.py

Author: rickecon

fiscalsim_us/tests/microsimulation/test_microsim.py

@@ -1,22 +1,38 @@
-def test_microsim_runs_cps():
-    import numpy as np
-    from fiscalsim_us import Microsimulation
+import numpy as np
+from fiscalsim_us import Microsimulation
+from policyengine_core.reforms import Reform
+from policyengine_core.periods import instant
+import pytest
+
+
+# @pytest.mark.skipif(True, reason="This test temporarily suspended.")
+
+"""
+In US nationwide simulations, use reported state income tax liabilities
+"""
+
 
-    sim = Microsimulation()
-    hnet = sim.calc("household_net_income")
+def use_reported_state_income_tax(parameters):
+    parameters.simulation.reported_state_income_tax.update(
+        start=instant("2024-01-01"), stop=instant("2100-12-31"), value=True
+    )
+    return parameters
+
+
+class baseline_reform(Reform):
+    def apply(self):
+        self.modify_parameters(use_reported_state_income_tax)
+
+
+def test_microsim_runs_cps():
+    sim = Microsimulation(reform=baseline_reform)
+    hnet = sim.calc("household_net_income", period=2024, map_to="person")
     assert not hnet.isna().any(), "Some households have NaN net income."
-    # Deciles are 1-10, with -1 for negative income.
-    DECILES = [
-        "household_income_decile",
-        "spm_unit_income_decile",
-        "income_decile",
-    ]
-    for decile_var in DECILES:
-        decile = sim.calc(decile_var)
-        assert np.all(decile >= -1) and np.all(
-            decile <= 10
-        ), f"{decile_var} out of bounds."
-
-    # Check that the microsim calculates important variables as nonzero in current year.
-    for var in ["employment_income", "self_employment_income"]:
-        assert sim.calc(var, period=2024).sum() > 0, f"{var} is zero in 2024."
+    hidecile = sim.calc(
+        "household_income_decile", period=2024, map_to="person"
+    )
+    assert np.all(hidecile >= 1) and np.all(hidecile <= 10)
+    sidecile = sim.calc("spm_unit_income_decile", period=2024, map_to="person")
+    assert np.all(sidecile >= 1) and np.all(sidecile <= 10)
+    idecile = sim.calc("income_decile", period=2024, map_to="person")
+    assert np.all(idecile >= 1) and np.all(idecile <= 10)