Skip to content

Commit 887dfd8

Browse files
Fixed some warnings in RobotPose
1 parent ec4f580 commit 887dfd8

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

include/franky/robot_pose.hpp

+11-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ class RobotPose {
1414

1515
RobotPose(const RobotPose &robot_pose);
1616

17+
// Suppress implicit conversion warning
18+
#pragma clang diagnostic push
19+
#pragma clang diagnostic ignored "-Wimplicit-conversion"
1720
RobotPose(Affine end_effector_pose, std::optional<double> elbow_position = std::nullopt);
21+
#pragma clang diagnostic pop
1822

1923
explicit RobotPose(const Vector7d &vector_repr, bool ignore_elbow = false);
2024

@@ -27,15 +31,19 @@ class RobotPose {
2731
[[nodiscard]] franka::CartesianPose as_franka_pose() const;
2832

2933
[[nodiscard]] inline RobotPose left_transform(const Affine &transform) const {
30-
return RobotPose(transform * end_effector_pose_, elbow_position_);
34+
return {transform * end_effector_pose_, elbow_position_};
3135
}
3236

3337
[[nodiscard]] inline RobotPose right_transform(const Affine &transform) const {
34-
return RobotPose(end_effector_pose_ * transform, elbow_position_);
38+
return {end_effector_pose_ * transform, elbow_position_};
39+
}
40+
41+
[[nodiscard]] inline RobotPose changeEndEffectorFrame(const Affine &transform) const {
42+
return {end_effector_pose_ * transform.inverse(), elbow_position_};
3543
}
3644

3745
[[nodiscard]] inline RobotPose with_elbow_position(const std::optional<double> elbow_position) const {
38-
return RobotPose(end_effector_pose_, elbow_position);
46+
return {end_effector_pose_, elbow_position};
3947
}
4048

4149
[[nodiscard]] inline Affine end_effector_pose() const {

0 commit comments

Comments
 (0)