Skip to content

Commit 01b74d1

Browse files
committed
doc: require passing CI for landing code
PR-URL: nodejs#19458 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
1 parent a72bfb9 commit 01b74d1

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

COLLABORATOR_GUIDE.md

+8
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,14 @@ and must be subjected to continuous integration tests on the
196196
[project CI server](https://ci.nodejs.org/). The pull request should have a CI
197197
status indicator.
198198

199+
Do not land any Pull Requests without passing (green or yellow) CI runs. If you
200+
believe any failed (red or grey) CI sub-tasks are unrelated to the change in the
201+
Pull Request, you may re-run the sub-task to try to see if it passes. If re-runs
202+
of all failed sub-tasks pass, it is permissible to land the Pull Request but
203+
only if the initial failures are believed in good faith to be unrelated to the
204+
changes in the Pull Request. Otherwise, reasonable steps must be taken to
205+
confirm that the changes are not resulting in an unreliable test.
206+
199207
#### Useful CI Jobs
200208

201209
* [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)

0 commit comments

Comments
 (0)