Skip to content

Commit 10642d6

Browse files
committed
tools: report unused disable-directives for ESLint
Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives PR-URL: nodejs#25119 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent b0a334b commit 10642d6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1159,7 +1159,7 @@ lint-md: | tools/.mdlintstamp
11591159
LINT_JS_TARGETS = .eslintrc.js benchmark doc lib test tools
11601160

11611161
run-lint-js = tools/node_modules/eslint/bin/eslint.js --cache \
1162-
--ext=.js,.mjs,.md $(LINT_JS_TARGETS)
1162+
--report-unused-disable-directives --ext=.js,.mjs,.md $(LINT_JS_TARGETS)
11631163
run-lint-js-fix = $(run-lint-js) --fix
11641164

11651165
.PHONY: lint-js-fix

vcbuild.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ if defined lint_js_ci goto lint-js-ci
632632
if not defined lint_js goto lint-md-build
633633
if not exist tools\node_modules\eslint goto no-lint
634634
echo running lint-js
635-
%config%\node tools\node_modules\eslint\bin\eslint.js --cache --rule "linebreak-style: 0" --ext=.js,.mjs,.md .eslintrc.js benchmark doc lib test tools
635+
%config%\node tools\node_modules\eslint\bin\eslint.js --cache --report-unused-disable-directives --rule "linebreak-style: 0" --ext=.js,.mjs,.md .eslintrc.js benchmark doc lib test tools
636636
goto lint-md-build
637637

638638
:lint-js-ci

0 commit comments

Comments
 (0)