src: Handle bad callback in asyc_wrap

HarshithaKP · gireeshpunathil · commit 757e2037e74f · 2020-03-05T12:30:29.000+05:30
Align with the MaybeLocal<> API contract PR-URL: nodejs#31946 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/async_wrap-inl.h b/src/async_wrap-inl.h
@@ -74,9 +74,8 @@ inline v8::MaybeLocal<v8::Value> AsyncWrap::MakeCallback(
   if (!object()->Get(env()->context(), symbol).ToLocal(&cb_v))
     return v8::MaybeLocal<v8::Value>();
   if (!cb_v->IsFunction()) {
-    // TODO(addaleax): We should throw an error here to fulfill the
-    // `MaybeLocal<>` API contract.
-    return v8::MaybeLocal<v8::Value>();
+    v8::Isolate* isolate = env()->isolate();
+    return Undefined(isolate);
   }
   return MakeCallback(cb_v.As<v8::Function>(), argc, argv);
 }

Original file line number	Diff line number	Diff line change
`@@ -74,9 +74,8 @@ inline v8::MaybeLocal<v8::Value> AsyncWrap::MakeCallback(`
`74`	`74`	`if (!object()->Get(env()->context(), symbol).ToLocal(&cb_v))`
`75`	`75`	`return v8::MaybeLocal<v8::Value>();`
`76`	`76`	`if (!cb_v->IsFunction()) {`
`77`		`- // TODO(addaleax): We should throw an error here to fulfill the`
`78`		- // `MaybeLocal<>` API contract.
`79`		`- return v8::MaybeLocal<v8::Value>();`
	`77`	`+ v8::Isolate* isolate = env()->isolate();`
	`78`	`+ return Undefined(isolate);`
`80`	`79`	`}`
`81`	`80`	`return MakeCallback(cb_v.As<v8::Function>(), argc, argv);`
`82`	`81`	`}`