Skip to content

Commit f3e078f

Browse files
committed
doc: reduce CI options in COLLABORATOR_GUIDE.md
PR-URL: nodejs#19458 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
1 parent be47094 commit f3e078f

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

COLLABORATOR_GUIDE.md

+4-8
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,9 @@ All bugfixes require a test case which demonstrates the defect. The
192192
test should *fail* before the change, and *pass* after the change.
193193

194194
All pull requests that modify executable code should also include a test case
195-
and be subjected to continuous integration tests on the
195+
and must be subjected to continuous integration tests on the
196196
[project CI server](https://ci.nodejs.org/). The pull request should have a CI
197-
status indicator if possible.
197+
status indicator.
198198

199199
#### Useful CI Jobs
200200

@@ -203,13 +203,9 @@ is the standard CI run we do to check Pull Requests. It triggers
203203
`node-test-commit`, which runs the `build-ci` and `test-ci` targets on all
204204
supported platforms.
205205

206-
* [`node-test-linter`](https://ci.nodejs.org/job/node-test-linter/)
207-
only runs the linter targets, which is useful for changes that only affect
208-
comments or documentation.
209-
210206
* [`node-test-pull-request-lite`](https://ci.nodejs.org/job/node-test-pull-request-lite/)
211-
only runs the linter job, as well as the tests on LinuxONE. Should only be used
212-
for trivial changes that do not require being tested on all platforms.
207+
only runs the linter job, as well as the tests on LinuxONE, which is very fast.
208+
This is useful for changes that only affect comments or documentation.
213209

214210
* [`citgm-smoker`](https://ci.nodejs.org/job/citgm-smoker/)
215211
uses [`CitGM`](https://github.com/nodejs/citgm) to allow you to run

0 commit comments

Comments
 (0)