Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on 0.10.38 finalizing a statement while aborting an https request #439

Closed
briangreenery opened this issue Apr 15, 2015 · 4 comments
Closed

Comments

@briangreenery
Copy link
Contributor

I'm seeing a node.js assertion failure that causes node to crash if I abort() an https request and finalize() a statement during the https 'response' event.

Node crashes with:

node: ../src/node_http_parser.cc:459: static v8::Handle<v8::Value> node::Parser::Finish(const v8::Arguments&): Assertion `!current_buffer' failed.

Here's code that causes the crash:

https://gist.github.com/briangreenery/bbb917b470e958626167

I've reproduced this on node 0.10.38 on Ubuntu 14.04 and Mac.
I have not been able to reproduce this on 0.12.2 or io.js 1.7.1. I also have not been able to reproduce this on 0.10.38 on Windows.

It seems like a work-around is to defer calling finalize() until process.nextTick.

@springmeyer
Copy link
Contributor

This crash is happening in node.js itself and not node-sqlite3. Have you considered filing a ticket upstream at node?

@briangreenery
Copy link
Contributor Author

I didn't. I'm not familiar enough with this module to know whether it's a bug in node itself. I wonder if it's related to nodejs/nan#284 though.

@springmeyer
Copy link
Contributor

k, looks like at least one other similiar report at nodejs/node-v0.x-archive#1574

@daniellockyer
Copy link
Member

Closing as it doesn't seem related to node-sqlite3 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants