-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements for maintainability #24
Comments
#23 for dependabot configuration |
#28 for migrating to uv |
#30 for docs build |
One issue that I will add for discussion - VI is slow to onboard new models because of the strong coupling between code and configuration. We currently bundle the job config with the VI package. This means that users need update their VI package to add a few lines to their models.csv which doesn't feel great. |
@XkunW We are also missing developer documentation. The user facing documentation is relatively clear but it would be good to expand the documentation with a contribution guide. |
Update @jwilles, @XkunW I tested a custom model - https://huggingface.co/Qwen/Qwen2.5-7B-Instruct-1M. Works! I will be updating the documentation shortly on how users can onboard their own models. |
I like this package and quite interested to make it work for my use case, just want to confirm if there are any plans to support the following use cases?
Thanks for your work, it's quite useful :) |
@rohan-uiuc thanks for your interest. Can you elaborate on 1. and give an example usage? If I understand it better, perhaps it can be a feature request for us. Regarding 2. and 3. I think my colleague @jwilles might have a better idea. |
@amrit110 thanks for the quick response. About 1, it's about the ability to enable using this package natively via python scripts/applications. I was playing around yesterday, let me open a PR for your reference. I didn't have a great way to test as it will need several manual changes to make it work on my cluster, which I might attempt in the coming week.
|
I've opened #54 . Please feel free to leave comments or make improvements as I cannot manually test it yet. I will be happy to contribute with some more features like adding an apptainer |
@rohan-uiuc Thanks for your contribution! Regarding point 2 and 3, we have plans on the roadmap to decouple the config with our current cluster setup for better generalizability, so stay tuned on that. We're also in the process of automating the deployment of the singularity container ( |
vector-inference is starting to expand to more models and has onboarded users. I'm looking to contribute by helping improve its maintainability. Concretely, I have 4 tasks in mind:
The text was updated successfully, but these errors were encountered: