-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Didn't work for me, nothing rendered on the screen! #1
Comments
Hey @hack-and-backslash sorry for the response delay. I'll spend time to understand why it doesn't work on your own app. Can you copy past the component using this lib ? Mine is:
|
I am doing the same thing. Nothing gets rendered on screen for me. Here's my class: export default class App extends Component { |
Ok i'll see it ASAP. Are you sure that you have a Edit: my comment above has been updated to explicit the |
In ios, it is working fine but in android its show nothing. I guess fragment is causing some problem to render any confetti. |
Hi @Tracklous & @hack-and-backslash i'm reproducing your issue locally. I'm looking to fix this ASAP and release a patch for this and back to you. Don't know if it's related to this fix (in 0.59): facebook/react-native#18872 |
Ok guys, I identified the root cause. In debug mode, it's working, but not without debug mode. It seems that it's related to facebook/react-native#18426 I'll find a workaround or change the code to fix this. Stay tuned |
@hack-and-backslash @Tracklous a new version was published (1.1.2).
|
Hi! @VincentCATILLON , It is running on Android now, but after the little fix " Array(count).fill(count).map(...." I've to give the args to the fill() function so I just passed the count in it. But there are also some performance issues whenever I put the count to greater than 70-80 confetti's then it performs the animation in <60 FPS. Anyways thanx for the quick response. |
Yes, i think it depends on device CPU. We could use The solution could be to make it natively and expose it to JS through RN bridge. |
I'm closing the issue if it's right for you so :) Have a great day |
Eveything seems fine now. Thanks. |
Same issue. I'm using react-native-confetti-cannon@^1.1.2 and React native 0.59.10 |
Remove prepare script
I was looking for such a thing since a week now and found this one. Unfortunately, it doesn't work for me. Neither does it throw any errors or log anything to the console.
Using:
"react": "16.6.3",
"react-native": "0.58.6",
"react-native-confetti-cannon": "^1.0.2",
The text was updated successfully, but these errors were encountered: