Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adjust is_lower_than_or_equal validations to account for an optional threshold #42

Open
asfakianakis opened this issue Jan 4, 2023 · 0 comments
Assignees

Comments

@asfakianakis
Copy link

asfakianakis commented Jan 4, 2023

Context

Currently the is_lower_than_or_equal , is_greater_than_or_equal etc. validations will raise an exception even if there's a single row that violates the provided condition.

Desired functionality

We would like to make this behaviour optionally "slacked", by providing an optional argument that it will indicate the minimum number of DataFrame rows that should violate the provided validation in order to raise an Exception. For example this could like sth like this:

validations:
    is_greater_than_or_equal:
      apply: true
      options:
        threshold: 100
        min_rows: 20

This means that the validation would throw an exception only if a DtaFrame has more than 20 rows where the values are < 100.

@asfakianakis asfakianakis self-assigned this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant